Bug 76058 – Web Inspector: [TextPrompt] Autocomplete adds unwanted text that's hard to remove

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Alexander Pavlov (apavlov)]

What steps will reproduce the problem?
1. Open the Web Inspector
2. Type in the console: str.replace(/is/, 'was')
3. Try to type a "g" after /is/ to make it a global replace

What is the expected result?
A "g". That's it. Just a "g".

What happens instead?
The 'smart' autocomplete adds 'getComputedStyle' and it won't go away! If you backspace, you backspace the last letter of getComputedStyle, not the whole thing. If you backspace all the way back, it just adds "etComputedStyle" again. If you ESC it's gone for half a second and than it's there again.

It's not only annoying, it actually breaks functionality! The new autocomplete is a little too eager.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=109518

[Alexander Pavlov (apavlov)]

Created attachment 122027 [details]
Patch

[Pavel Feldman]

Comment on attachment 122027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122027&action=review

> Source/WebCore/ChangeLog:8
> +        - Avoid showing suggestions when navigating through the user input.

Could you add a test that emits Right, Right, Right on various user inputs and checks that popup is never shown?

> Source/WebCore/ChangeLog:9
> +        - Don't complete the grayed (non-selected) suggestion with Right or End.

Lets wait before we do this one.

[Alexander Pavlov (apavlov)]

Created attachment 122395 [details]
Patch

[WebKit Review Bot]

Comment on attachment 122395 [details]
Patch

Attachment 122395 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11227511

New failing tests:
inspector/styles/styles-cancel-editing.html

[Alexander Pavlov (apavlov)]

Created attachment 122442 [details]
Patch

Add PageUp/PageDown handling in suggest box

[WebKit Review Bot]

Comment on attachment 122442 [details]
Patch

Attachment 122442 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11236089

New failing tests:
inspector/styles/styles-cancel-editing.html

[Alexander Pavlov (apavlov)]

Created attachment 122625 [details]
Patch

[PATCH] Fix test failure

[Alexander Pavlov (apavlov)]

Created attachment 122747 [details]
Patch

[Alexander Pavlov (apavlov)]

Committed r105140: <http://trac.webkit.org/changeset/105140>