Bug 76054

Summary: [GTK] Web process should use the same locale as the UI process
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gns, pnormand
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch gns: review+

Description Carlos Garcia Campos 2012-01-11 05:30:34 PST
For example, unit tests are run with C locale, because gtk_init_test() calls setlocale, but the web process is run with the system locole.
Comment 1 Carlos Garcia Campos 2012-01-11 05:32:11 PST
Created attachment 122011 [details]
Patch
Comment 2 Philippe Normand 2012-01-11 05:38:18 PST
(In reply to comment #0)
> For example, unit tests are run with C locale, because gtk_init_test() calls setlocale, but the web process is run with the system locole.

Shouldn't the WebProcess only set the locale when runned in the tests context then?
Comment 3 Carlos Garcia Campos 2012-01-11 05:41:04 PST
unit tests is just and example, this way we make sure locale will be the same.
Comment 4 Gustavo Noronha (kov) 2012-01-11 05:42:42 PST
Comment on attachment 122011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122011&action=review

That looks fine to me. I wondered the same thing as Philippe, but I realized having the same locale for all processes would be desired in any case.

> Source/WebKit2/ChangeLog:3
> +        [GTK] Web process should use the same locale than UI process

I think 'than' is not correct in this case, I think 'as the' would be (notice I am not a native speaker, though)
Comment 5 Carlos Garcia Campos 2012-01-11 05:43:00 PST
I mean, the application using wk2 api might call setlocale(). Currently that would only affect the ui process.
Comment 6 Philippe Normand 2012-01-11 05:47:37 PST
(In reply to comment #5)
> I mean, the application using wk2 api might call setlocale(). Currently that would only affect the ui process.

Ok thanks for the clarification.
Comment 7 Carlos Garcia Campos 2012-01-11 22:59:15 PST
Committed r104792: <http://trac.webkit.org/changeset/104792>