Bug 76054 – [GTK] Web process should use the same locale as the UI process

• Component: WebKit2
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

For example, unit tests are run with C locale, because gtk_init_test() calls setlocale, but the web process is run with the system locole.

[Carlos Garcia Campos]

Created attachment 122011 [details]
Patch

[Philippe Normand]

(In reply to comment #0)
> For example, unit tests are run with C locale, because gtk_init_test() calls setlocale, but the web process is run with the system locole.

Shouldn't the WebProcess only set the locale when runned in the tests context then?

[Carlos Garcia Campos]

unit tests is just and example, this way we make sure locale will be the same.

[Gustavo Noronha (kov)]

Comment on attachment 122011 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122011&action=review

That looks fine to me. I wondered the same thing as Philippe, but I realized having the same locale for all processes would be desired in any case.

> Source/WebKit2/ChangeLog:3
> +        [GTK] Web process should use the same locale than UI process

I think 'than' is not correct in this case, I think 'as the' would be (notice I am not a native speaker, though)

[Carlos Garcia Campos]

I mean, the application using wk2 api might call setlocale(). Currently that would only affect the ui process.

[Philippe Normand]

(In reply to comment #5)
> I mean, the application using wk2 api might call setlocale(). Currently that would only affect the ui process.

Ok thanks for the clarification.

[Carlos Garcia Campos]

Committed r104792: <http://trac.webkit.org/changeset/104792>