| Summary: | [GTK] Web process should use the same locale as the UI process | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | gustavo, pnormand | ||||
| Priority: | P2 | Keywords: | Gtk | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2012-01-11 05:30:34 PST
Created attachment 122011 [details]
Patch
(In reply to comment #0) > For example, unit tests are run with C locale, because gtk_init_test() calls setlocale, but the web process is run with the system locole. Shouldn't the WebProcess only set the locale when runned in the tests context then? unit tests is just and example, this way we make sure locale will be the same. Comment on attachment 122011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122011&action=review That looks fine to me. I wondered the same thing as Philippe, but I realized having the same locale for all processes would be desired in any case. > Source/WebKit2/ChangeLog:3 > + [GTK] Web process should use the same locale than UI process I think 'than' is not correct in this case, I think 'as the' would be (notice I am not a native speaker, though) I mean, the application using wk2 api might call setlocale(). Currently that would only affect the ui process. (In reply to comment #5) > I mean, the application using wk2 api might call setlocale(). Currently that would only affect the ui process. Ok thanks for the clarification. Committed r104792: <http://trac.webkit.org/changeset/104792> |