Summary: | CSSStyleSelector constructor and appendAuthorStylesheets() contain duplicated code | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roland Steiner <rolandsteiner> | ||||||||
Component: | CSS | Assignee: | Roland Steiner <rolandsteiner> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, dominicc, hyatt, koivisto, macpherson, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 73190 | ||||||||||
Attachments: |
|
Description
Roland Steiner
2012-01-11 02:33:14 PST
Created attachment 121998 [details]
Patch
Comment on attachment 121998 [details]
Patch
I don't think this is right factoring. We will need to do collectFeatures differently in append case to avoid going through all the stylesheets again. We don't generally use iterators with Vectors. I'd like to eliminate the pointless StyleSheetVector typedef.
Created attachment 122579 [details]
new patch, smaller
New, smaller patch. Adds a const-accessor for the vector to StyleSheetList. Perhaps not terribly elegant, but it's a) const only and b) there's a precedent with StyleSheetList::swap(). This way no iterators are necessary (still using 'StyleSheetVector' within StyleSheetList for consistency).
Comment on attachment 122579 [details] new patch, smaller Attachment 122579 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11214031 Comment on attachment 122579 [details] new patch, smaller Attachment 122579 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11251031 Comment on attachment 122579 [details] new patch, smaller Attachment 122579 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11254025 Created attachment 122583 [details]
new patch, fixed
Comment on attachment 122583 [details]
new patch, fixed
r=me
Comment on attachment 122583 [details] new patch, fixed Clearing flags on attachment: 122583 Committed r105052: <http://trac.webkit.org/changeset/105052> All reviewed patches have been landed. Closing bug. |