Summary: | Rename HTMLInputElement::setDefaultName to setInitialName | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | darin, webkit.review.bot | ||||
Priority: | P3 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Kent Tamura
2012-01-11 01:13:34 PST
> this doesn’t actually work correctly if a name is added and then subsequently removed from the isindex element.
I confirmed the current behavior of WebKit is compatible with IE9, Firefox, and Opera. As you wrote, setDefaultName() really sets just an initial name.
Created attachment 121994 [details]
Patch
Comment on attachment 121994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121994&action=review > Source/WebCore/html/HTMLInputElement.cpp:1305 > + ASSERT(hasTagName(isindexTag)); To me it seems like this assert goes a little overboard, but only a tiny bit, so I say, lets keep it. Comment on attachment 121994 [details] Patch Clearing flags on attachment: 121994 Committed r104747: <http://trac.webkit.org/changeset/104747> All reviewed patches have been landed. Closing bug. |