Bug 76031

Summary:

[EFL] Unused code cleanup on ewk_tiled_model.cpp.

Product:

WebKit

Reporter:

KwangHyuk <hyuki.kim>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch.	rniwa: review+, rniwa: commit-queue-
Update ChangeLog.	none
Update ChangeLog.	none

KwangHyuk

Reported 2012-01-10 23:00:05 PST

From the ewk_tiled_model.cpp, as _ewk_tile_paint is never used, it and two callee APIs which are only used by it will be removed.

Attachments
Patch. (3.23 KB, patch) 2012-01-11 19:18 PST, KwangHyuk	rniwa: review+ rniwa: commit-queue-	Details Formatted Diff Diff
Update ChangeLog. (3.20 KB, patch) 2012-01-12 23:23 PST, KwangHyuk	no flags	Details Formatted Diff Diff
Update ChangeLog. (3.20 KB, patch) 2012-01-12 23:26 PST, KwangHyuk	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

KwangHyuk

Comment 1 2012-01-11 19:18:08 PST

Created attachment 122156 [details] Patch.

Gyuyoung Kim

Comment 2 2012-01-11 19:23:26 PST

Comment on attachment 122156 [details] Patch. Though this functions are internal functions, I think you need to notify this removal to webkit-efl mailing list first. Because, other guys may use this functions in future.

KwangHyuk

Comment 3 2012-01-11 19:25:33 PST

(In reply to comment #2) > (From update of attachment 122156 [details]) > Though this functions are internal functions, I think you need to notify this removal to webkit-efl mailing list first. Because, other guys may use this functions in future. Ok, I will. :)

KwangHyuk

Comment 4 2012-01-11 21:27:34 PST

(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 122156 [details] [details]) > > Though this functions are internal functions, I think you need to notify this removal to webkit-efl mailing list first. Because, other guys may use this functions in future. > > Ok, I will. :) I have announced the change. :)

Raphael Kubo da Costa (:rakuco)

Comment 5 2012-01-12 04:22:01 PST

Looks OK.

Ryosuke Niwa

Comment 6 2012-01-12 22:57:23 PST

Comment on attachment 122156 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=122156&action=review > Source/WebKit/efl/ChangeLog:8 > + As _ewk_tile_paint is never used, it and two callee APIs which are only used by it are removed. I don't really understand this description. Do you mean that callers of these two functions are removed? Please revise the description before landing it. Also this description is pretty long. You might want to wrap line somewhere.

KwangHyuk

Comment 7 2012-01-12 23:23:34 PST

Created attachment 122374 [details] Update ChangeLog.

KwangHyuk

Comment 8 2012-01-12 23:26:03 PST

Created attachment 122376 [details] Update ChangeLog.

WebKit Review Bot

Comment 9 2012-01-13 01:23:41 PST

Comment on attachment 122376 [details] Update ChangeLog. Clearing flags on attachment: 122376 Committed r104908: <http://trac.webkit.org/changeset/104908>

WebKit Review Bot

Comment 10 2012-01-13 01:23:46 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.