Bug 75988

Summary: [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

James Robinson
Reported 2012-01-10 13:18:14 PST
[chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
Attachments
Patch (8.97 KB, patch)
2012-01-10 13:18 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.94 KB, patch)
2012-01-10 14:16 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-01-10 13:18:57 PST
Created attachment 121899 [details] Patch
James Robinson
Comment 2 2012-01-10 13:22:49 PST
test-webkitpy worked and it ran the unit tests for me locally once. Not sure how else to check this.
Adam Barth
Comment 3 2012-01-10 13:36:19 PST
Comment on attachment 121899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121899&action=review > Tools/Scripts/webkitpy/common/config/ports.py:249 > + command = cls.script_shell_command("run-chromium-webkit-unit-tests") > + return command I would have combined these lines. > Tools/Scripts/webkitpy/tool/steps/runtests.py:69 > + Looks like you have an extra blank line here.
James Robinson
Comment 4 2012-01-10 14:16:27 PST
Created attachment 121908 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-01-10 15:35:49 PST
Comment on attachment 121908 [details] Patch for landing Clearing flags on attachment: 121908 Committed r104638: <http://trac.webkit.org/changeset/104638>
WebKit Review Bot
Comment 6 2012-01-10 15:35:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.