Bug 75985

Summary: CodeBlock::m_numParameters should be encapsulated
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch oliver: review+

Filip Pizlo
Reported 2012-01-10 12:50:37 PST
Patch forthcoming.
Attachments
the patch (23.45 KB, patch)
2012-01-10 13:33 PST, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-01-10 12:51:10 PST
<rdar://problem/10671020>
Filip Pizlo
Comment 2 2012-01-10 13:33:49 PST
Created attachment 121900 [details] the patch Seems neutral. [pizlo@nitroflex bencher] ./bencher TipOfTree:/Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc RfctrNumParam:/Volumes/Data/pizlo/OpenSource/WebKitBuild/Release/jsc --remote bigmac,oldmac --local Copying TipOfTree into /Volumes/Data/pizlo/bencher/temp/benchdata... Copying RfctrNumParam into /Volumes/Data/pizlo/bencher/temp/benchdata... All VMs are in place. Packaging benchmarking directory for remote hosts... Sending benchmark payload to bigmac... Running on bigmac... 376/376 Generating benchmark report at TipOfTree_RfctrNumParam_SunSpiderV8Kraken_bigmac_20120110_1309_benchReport.txt Benchmark report for SunSpider, V8, and Kraken on bigmac (MacPro5,1). VMs tested: "TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc (r104613) "RfctrNumParam" at /Volumes/Data/pizlo/OpenSource/WebKitBuild/Release/jsc (r104613) Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark. Emitted a call to gc() between sample measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the jsc-specific preciseTime() function to get microsecond-level timing. Reporting benchmark execution times with 95% confidence intervals in milliseconds. TipOfTree RfctrNumParam SunSpider: 3d-cube 5.8683+-0.0181 ! 5.9354+-0.0145 ! definitely 1.0114x slower 3d-morph 8.4685+-0.0902 8.4185+-0.0714 3d-raytrace 7.8394+-0.0584 7.8346+-0.0468 access-binary-trees 1.6051+-0.0060 ? 1.6086+-0.0100 ? access-fannkuch 7.5068+-0.0582 7.4632+-0.0418 access-nbody 3.9616+-0.0075 ? 3.9708+-0.0048 ? access-nsieve 3.1296+-0.0404 ? 3.1675+-0.0605 ? might be 1.0121x slower bitops-3bit-bits-in-byte 1.2497+-0.0115 ? 1.2555+-0.0136 ? bitops-bits-in-byte 5.0360+-0.0315 5.0221+-0.0458 bitops-bitwise-and 3.3961+-0.1008 3.3911+-0.0970 bitops-nsieve-bits 5.6554+-0.0382 5.6373+-0.0346 controlflow-recursive 2.3302+-0.0076 ? 2.3433+-0.0180 ? crypto-aes 7.5072+-0.1635 7.3696+-0.0301 might be 1.0187x faster crypto-md5 2.4991+-0.0276 ? 2.5415+-0.0324 ? might be 1.0170x slower crypto-sha1 2.2877+-0.0089 ? 2.2984+-0.0159 ? date-format-tofte 10.6542+-0.1226 ? 10.7796+-0.1434 ? might be 1.0118x slower date-format-xparb 9.7879+-0.0417 ! 10.1586+-0.0833 ! definitely 1.0379x slower math-cordic 7.3127+-0.0989 7.2762+-0.0476 math-partial-sums 10.5211+-0.0368 10.4998+-0.0639 math-spectral-norm 2.6520+-0.0154 2.6474+-0.0039 regexp-dna 8.8970+-0.0127 ! 9.0567+-0.0893 ! definitely 1.0180x slower string-base64 4.3556+-0.0421 ^ 4.2931+-0.0130 ^ definitely 1.0146x faster string-fasta 7.2574+-0.0206 7.2566+-0.0258 string-tagcloud 12.3251+-0.0567 ! 12.4417+-0.0391 ! definitely 1.0095x slower string-unpack-code 20.4763+-0.1440 ? 20.5627+-0.0549 ? string-validate-input 5.6144+-0.0309 ^ 5.5323+-0.0324 ^ definitely 1.0148x faster <arithmetic> * 6.4690+-0.0243 ? 6.4909+-0.0209 ? might be 1.0034x slower <geometric> 5.2735+-0.0205 ? 5.2865+-0.0220 ? might be 1.0025x slower <harmonic> 4.1883+-0.0183 ? 4.1999+-0.0222 ? might be 1.0028x slower TipOfTree RfctrNumParam V8: crypto 77.9880+-0.3012 77.6291+-0.2856 deltablue 171.1756+-1.2006 ! 173.8017+-1.0390 ! definitely 1.0153x slower earley-boyer 99.4807+-1.1543 ? 99.6217+-0.8499 ? raytrace 51.2460+-0.2566 ? 51.2726+-0.1109 ? regexp 118.4736+-0.6294 ? 119.3783+-0.3546 ? richards 137.0357+-0.4192 ? 138.1799+-0.7674 ? splay 92.4658+-1.4322 ? 92.6360+-1.5458 ? <arithmetic> 106.8379+-0.3346 ? 107.5028+-0.3544 ? might be 1.0062x slower <geometric> * 100.2996+-0.3226 ? 100.7358+-0.3362 ? might be 1.0043x slower <harmonic> 93.5915+-0.3170 ? 93.8412+-0.3017 ? might be 1.0027x slower TipOfTree RfctrNumParam Kraken: ai-astar 817.6216+-10.4685 ? 827.8829+-0.7681 ? might be 1.0126x slower audio-beat-detection 192.2483+-0.7113 191.8314+-0.6771 audio-dft 274.6441+-2.0212 ? 275.8626+-1.5501 ? audio-fft 119.8347+-0.9139 ? 120.0442+-1.1719 ? audio-oscillator 280.8818+-2.1622 280.4128+-1.9432 imaging-darkroom 304.4767+-9.2157 301.2759+-7.2255 might be 1.0106x faster imaging-desaturate 229.9158+-0.0687 ? 230.0034+-0.0640 ? imaging-gaussian-blur 519.6653+-1.1099 519.5721+-0.4877 json-parse-financial 68.0139+-0.2153 ! 68.9786+-0.3429 ! definitely 1.0142x slower json-stringify-tinderbox 80.9312+-1.0978 ! 85.3001+-1.4029 ! definitely 1.0540x slower stanford-crypto-aes 115.6784+-0.2686 ? 115.9618+-0.6682 ? stanford-crypto-ccm 108.7447+-0.8759 ? 109.5120+-1.1911 ? stanford-crypto-pbkdf2 215.1478+-0.5469 ? 215.8661+-0.5456 ? stanford-crypto-sha256-iterative 94.7657+-0.4536 ^ 93.6657+-0.1614 ^ definitely 1.0117x faster <arithmetic> * 244.4693+-1.1735 ? 245.4407+-0.5786 ? might be 1.0040x slower <geometric> 189.0543+-0.6567 ? 190.0362+-0.4414 ? might be 1.0052x slower <harmonic> 152.7654+-0.4600 ! 154.1267+-0.4529 ! definitely 1.0089x slower TipOfTree RfctrNumParam All benchmarks: <arithmetic> 92.3113+-0.3904 ? 92.7117+-0.2022 ? might be 1.0043x slower <geometric> 23.7495+-0.0729 ? 23.8340+-0.0715 ? might be 1.0036x slower <harmonic> 7.3734+-0.0316 ? 7.3945+-0.0382 ? might be 1.0029x slower TipOfTree RfctrNumParam Geomean of preferred means: <scaled-result> 54.1316+-0.1628 ? 54.3429+-0.1260 ? might be 1.0039x slower Sending benchmark payload to oldmac... Running on oldmac... 376/376 Generating benchmark report at TipOfTree_RfctrNumParam_SunSpiderV8Kraken_oldmac_20120110_1312_benchReport.txt Benchmark report for SunSpider, V8, and Kraken on oldmac (MacPro4,1). VMs tested: "TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc (r104613) "RfctrNumParam" at /Volumes/Data/pizlo/OpenSource/WebKitBuild/Release/jsc (r104613) Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark. Emitted a call to gc() between sample measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the jsc-specific preciseTime() function to get microsecond-level timing. Reporting benchmark execution times with 95% confidence intervals in milliseconds. TipOfTree RfctrNumParam SunSpider: 3d-cube 7.0533+-0.0265 ! 7.1614+-0.0341 ! definitely 1.0153x slower 3d-morph 10.6125+-0.1990 ^ 10.2576+-0.1293 ^ definitely 1.0346x faster 3d-raytrace 9.4088+-0.0557 9.3565+-0.0422 access-binary-trees 1.9282+-0.0181 1.9233+-0.0074 access-fannkuch 9.0700+-0.0679 ? 9.0965+-0.0582 ? access-nbody 4.8020+-0.0157 4.7983+-0.0112 access-nsieve 3.7470+-0.0593 3.7413+-0.0499 bitops-3bit-bits-in-byte 1.5143+-0.0164 1.4961+-0.0053 might be 1.0122x faster bitops-bits-in-byte 6.1203+-0.1022 ? 6.1538+-0.1273 ? bitops-bitwise-and 4.0384+-0.0923 ? 4.1048+-0.1138 ? might be 1.0164x slower bitops-nsieve-bits 6.8230+-0.0447 ? 6.8315+-0.0461 ? controlflow-recursive 2.8277+-0.0286 2.8211+-0.0153 crypto-aes 8.8718+-0.0408 ? 8.9188+-0.0501 ? crypto-md5 2.9864+-0.0363 ? 3.0160+-0.0315 ? crypto-sha1 2.7370+-0.0076 ? 2.7512+-0.0194 ? date-format-tofte 12.8502+-0.1035 ? 12.9286+-0.1492 ? date-format-xparb 12.2060+-0.0997 ! 12.8293+-0.4358 ! definitely 1.0511x slower math-cordic 8.7722+-0.0351 ? 8.7931+-0.0392 ? math-partial-sums 12.6144+-0.0430 ? 12.6522+-0.0575 ? math-spectral-norm 3.2058+-0.0278 3.1985+-0.0083 regexp-dna 10.8020+-0.0458 ? 10.8300+-0.0775 ? string-base64 5.3186+-0.1814 5.1991+-0.0478 might be 1.0230x faster string-fasta 8.7312+-0.0575 8.7033+-0.0268 string-tagcloud 14.9391+-0.0466 ? 14.9752+-0.0451 ? string-unpack-code 25.6408+-0.1239 ? 25.7339+-0.0793 ? string-validate-input 6.7326+-0.0746 ? 6.7630+-0.0600 ? <arithmetic> * 7.8597+-0.0233 ? 7.8859+-0.0309 ? might be 1.0033x slower <geometric> 6.3771+-0.0232 ? 6.3892+-0.0259 ? might be 1.0019x slower <harmonic> 5.0516+-0.0229 5.0515+-0.0198 might be 1.0000x faster TipOfTree RfctrNumParam V8: crypto 93.6672+-0.2530 93.5594+-0.2925 deltablue 207.0785+-1.9827 ? 208.1339+-0.9415 ? earley-boyer 119.9952+-1.0407 ? 120.3941+-1.5951 ? raytrace 61.2435+-0.2262 ! 62.3009+-0.1626 ! definitely 1.0173x slower regexp 141.8403+-0.3131 ? 142.2910+-0.4716 ? richards 166.4466+-0.9872 ? 167.2947+-1.3159 ? splay 109.4022+-1.3063 ? 110.4139+-1.1222 ? <arithmetic> 128.5248+-0.3574 ? 129.1983+-0.3454 ? might be 1.0052x slower <geometric> * 120.4594+-0.2878 ! 121.1813+-0.3326 ! definitely 1.0060x slower <harmonic> 112.2304+-0.2509 ! 113.0520+-0.2988 ! definitely 1.0073x slower TipOfTree RfctrNumParam Kraken: ai-astar 896.6284+-0.5398 ? 897.3215+-0.5353 ? audio-beat-detection 234.2843+-0.7447 ? 234.4186+-1.1871 ? audio-dft 332.1705+-2.8228 330.9123+-2.3645 audio-fft 146.3395+-0.8246 ? 146.7152+-1.3583 ? audio-oscillator 342.4462+-4.3969 ? 347.6450+-5.3358 ? might be 1.0152x slower imaging-darkroom 362.0649+-8.2955 359.5454+-6.5532 imaging-desaturate 278.0760+-0.1537 278.0465+-0.3000 imaging-gaussian-blur 628.9836+-0.3563 628.5045+-0.4399 json-parse-financial 82.6112+-0.2405 ! 83.7096+-0.3755 ! definitely 1.0133x slower json-stringify-tinderbox 96.9675+-0.1525 ! 105.5802+-3.3886 ! definitely 1.0888x slower stanford-crypto-aes 139.9473+-0.6911 ^ 138.4198+-0.5331 ^ definitely 1.0110x faster stanford-crypto-ccm 130.6286+-1.4276 130.3296+-0.9957 stanford-crypto-pbkdf2 261.2039+-1.0815 ? 261.7020+-1.3393 ? stanford-crypto-sha256-iterative 115.7132+-0.7981 ^ 114.4264+-0.1691 ^ definitely 1.0112x faster <arithmetic> * 289.1475+-0.7690 ? 289.8055+-0.7100 ? might be 1.0023x slower <geometric> 227.2417+-0.5817 ! 228.5786+-0.5689 ! definitely 1.0059x slower <harmonic> 184.7135+-0.3882 ! 186.7508+-0.6046 ! definitely 1.0110x slower TipOfTree RfctrNumParam All benchmarks: <arithmetic> 109.6190+-0.2636 ? 109.9298+-0.2408 ? might be 1.0028x slower <geometric> 28.6389+-0.0836 ? 28.7444+-0.0856 ? might be 1.0037x slower <harmonic> 8.8930+-0.0397 ? 8.8950+-0.0343 ? might be 1.0002x slower TipOfTree RfctrNumParam Geomean of preferred means: <scaled-result> 64.9315+-0.1519 ? 65.1823+-0.1605 ? might be 1.0039x slower Running locally... 376/376 Generating benchmark report at TipOfTree_RfctrNumParam_SunSpiderV8Kraken_nitroflex_20120110_1314_benchReport.txt Benchmark report for SunSpider, V8, and Kraken on nitroflex (MacBookPro8,2). VMs tested: "TipOfTree" at /Volumes/Data/pizlo/quinary/OpenSource/WebKitBuild/Release/jsc (r104613) "RfctrNumParam" at /Volumes/Data/pizlo/OpenSource/WebKitBuild/Release/jsc (r104613) Collected 12 samples per benchmark/VM, with 4 VM invocations per benchmark. Emitted a call to gc() between sample measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the jsc-specific preciseTime() function to get microsecond-level timing. Reporting benchmark execution times with 95% confidence intervals in milliseconds. TipOfTree RfctrNumParam SunSpider: 3d-cube 5.5256+-0.4344 5.3185+-0.1520 might be 1.0389x faster 3d-morph 8.0966+-0.1702 8.0764+-0.1231 3d-raytrace 7.3347+-0.1750 ? 7.4635+-0.1790 ? might be 1.0176x slower access-binary-trees 1.5088+-0.0823 1.4646+-0.0221 might be 1.0302x faster access-fannkuch 5.8794+-0.0812 ? 6.0008+-0.0843 ? might be 1.0206x slower access-nbody 3.3144+-0.0793 3.2550+-0.0536 might be 1.0182x faster access-nsieve 2.5761+-0.0654 ? 2.6675+-0.0665 ? might be 1.0355x slower bitops-3bit-bits-in-byte 1.2288+-0.0156 ? 1.2608+-0.0227 ? might be 1.0261x slower bitops-bits-in-byte 2.3537+-0.0493 ? 2.4543+-0.0690 ? might be 1.0427x slower bitops-bitwise-and 3.2002+-0.0897 3.1750+-0.0526 bitops-nsieve-bits 5.4431+-0.1289 5.4071+-0.0992 controlflow-recursive 2.0270+-0.0399 1.9763+-0.0321 might be 1.0256x faster crypto-aes 7.3462+-0.2054 ? 7.3621+-0.2128 ? crypto-md5 2.3684+-0.0425 ? 2.4845+-0.0838 ? might be 1.0490x slower crypto-sha1 2.1564+-0.0377 2.1479+-0.0489 date-format-tofte 9.9488+-0.1123 ? 10.1208+-0.2443 ? might be 1.0173x slower date-format-xparb 9.6318+-0.4107 9.3481+-0.3072 might be 1.0303x faster math-cordic 6.4030+-0.0992 6.3398+-0.0941 math-partial-sums 7.5771+-0.1928 7.5371+-0.1411 math-spectral-norm 2.4076+-0.0690 2.3611+-0.0535 might be 1.0197x faster regexp-dna 7.9983+-0.1815 7.8419+-0.1399 might be 1.0199x faster string-base64 4.2585+-0.1070 4.1706+-0.0725 might be 1.0211x faster string-fasta 6.7665+-0.1316 ? 6.8324+-0.1435 ? string-tagcloud 11.3534+-0.2287 ? 11.3876+-0.2893 ? string-unpack-code 19.1889+-0.3231 19.0803+-0.4314 string-validate-input 5.2730+-0.1989 ? 5.3099+-0.1149 ? <arithmetic> * 5.8141+-0.0228 5.8017+-0.0331 might be 1.0021x faster <geometric> 4.6857+-0.0213 4.6846+-0.0191 might be 1.0002x faster <harmonic> 3.7294+-0.0258 ? 3.7374+-0.0163 ? might be 1.0021x slower TipOfTree RfctrNumParam V8: crypto 71.4174+-0.7500 ? 71.7696+-0.7334 ? deltablue 151.6468+-1.4288 ? 151.8994+-1.0678 ? earley-boyer 81.3277+-0.8987 80.8021+-0.8427 raytrace 47.4403+-0.3760 46.9299+-0.3002 might be 1.0109x faster regexp 102.3778+-1.3692 101.8832+-0.5037 richards 118.4247+-1.0375 ? 119.0488+-0.5125 ? splay 78.9634+-3.0659 77.2005+-0.9837 might be 1.0228x faster <arithmetic> 93.0854+-0.6091 92.7905+-0.3368 might be 1.0032x faster <geometric> * 87.7080+-0.6142 87.3150+-0.3467 might be 1.0045x faster <harmonic> 82.4572+-0.5794 81.9860+-0.3541 might be 1.0057x faster TipOfTree RfctrNumParam Kraken: ai-astar 481.8322+-3.0552 ? 486.2457+-3.4514 ? audio-beat-detection 173.7604+-0.5772 ? 174.0149+-1.0517 ? audio-dft 288.9352+-3.1809 288.6147+-4.3236 audio-fft 107.5737+-0.8168 ? 109.0944+-0.9194 ? might be 1.0141x slower audio-oscillator 252.6726+-2.0058 ? 254.2016+-1.8679 ? imaging-darkroom 278.1014+-11.9604 270.7786+-6.1103 might be 1.0270x faster imaging-desaturate 208.5960+-0.5692 ? 209.6103+-0.8521 ? imaging-gaussian-blur 487.5258+-2.3106 ? 490.0134+-1.9930 ? json-parse-financial 56.3911+-0.6143 ? 56.6638+-0.5727 ? json-stringify-tinderbox 72.0761+-0.5529 ! 73.4659+-0.3768 ! definitely 1.0193x slower stanford-crypto-aes 98.8736+-1.6470 98.2735+-1.3230 stanford-crypto-ccm 97.7449+-2.5981 96.2524+-0.8122 might be 1.0155x faster stanford-crypto-pbkdf2 181.6335+-1.7431 ? 181.7980+-1.8560 ? stanford-crypto-sha256-iterative 83.5018+-0.3917 ? 84.5018+-0.6968 ? might be 1.0120x slower <arithmetic> * 204.9442+-0.7089 ? 205.2521+-0.6205 ? might be 1.0015x slower <geometric> 164.9503+-0.5974 ? 165.3039+-0.4361 ? might be 1.0021x slower <harmonic> 134.0204+-0.6013 ? 134.5466+-0.3814 ? might be 1.0039x slower TipOfTree RfctrNumParam All benchmarks: <arithmetic> 78.1273+-0.2603 ? 78.1682+-0.2040 ? might be 1.0005x slower <geometric> 20.9382+-0.0686 20.9349+-0.0511 might be 1.0002x faster <harmonic> 6.5633+-0.0443 ? 6.5770+-0.0282 ? might be 1.0021x slower TipOfTree RfctrNumParam Geomean of preferred means: <scaled-result> 47.1026+-0.1560 47.0222+-0.1023 might be 1.0017x faster [pizlo@nitroflex bencher]
Filip Pizlo
Comment 3 2012-01-10 14:09:13 PST
Landed in http://trac.webkit.org/changeset/104630
Note You need to log in before you can comment on or make changes to this bug.