Bug 75962 – webkit-patch cannot rollout patches without changelog/bug number

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Kenneth Rohde Christiansen]

backtrace:

webkit-patch rollout 104569 Committed unreviewed code from wrong branch
Unable to parse bug number from diff.
Traceback (most recent call last):
  File "/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkit-patch", line 69, in <module>
    main()
  File "/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkit-patch", line 64, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/scratchbox/users/kenneth/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/scratchbox/users/kenneth/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/scratchbox/users/kenneth/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 46, in execute
    state = self._prepare_state(options, args, tool)
  File "/scratchbox/users/kenneth/home/kenneth/swork/Qt5/webkit/Tools/Scripts/webkitpy/tool/commands/download.py", line 348, in _prepare_state
    for party in commit_info.responsible_parties()
AttributeError: 'NoneType' object has no attribute 'responsible_parties'

[Kenneth Rohde Christiansen]

Anyone knows who to cc here?

[Csaba Osztrogonác]

(In reply to comment #1)
> Anyone knows who to cc here?
Sure. :)

[Eric Seidel (no email)]

Should be simple to fix and unittest.  Thanks for the report.

[Eric Seidel (no email)]

Created attachment 123160 [details]
Patch

[WebKit Review Bot]

Comment on attachment 123160 [details]
Patch

Clearing flags on attachment: 123160

Committed r105464: <http://trac.webkit.org/changeset/105464>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.