Bug 75911 – REGRESSION: d3 Bullet Charts demo doesn't work (call with argument assignment is broken)

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Geoffrey Garen]

http://mbostock.github.com/d3/ex/bullet.html

Displays no chart on ToT, but it works on Safari 5.1.2.

[Geoffrey Garen]

<rdar://problem/10650878>

[Geoffrey Garen]

Created attachment 121766 [details]
Patch

[Filip Pizlo]

Comment on attachment 121766 [details]
Patch

Yay!  r=me

[Filip Pizlo]

Any performance impact?

[Geoffrey Garen]

> Any performance impact?

Bencher says 1.002x worse on SunSpider and v8 -- seems reasonable to call that "no change".

Bytecode generation for f.apply is definitely worse by one op_mov. This is theoretically fixable with more robust optimization information in the AST, but I think that's probably the wrong direction -- long-term, we just want to compile f.apply in the DFG, which will elide the op_mov.

[Filip Pizlo]

(In reply to comment #5)
> > Any performance impact?
> 
> Bencher says 1.002x worse on SunSpider and v8 -- seems reasonable to call that "no change".
> 
> Bytecode generation for f.apply is definitely worse by one op_mov. This is theoretically fixable with more robust optimization information in the AST, but I think that's probably the wrong direction -- long-term, we just want to compile f.apply in the DFG, which will elide the op_mov.

Agree!

[Geoffrey Garen]

Committed r104762: <http://trac.webkit.org/changeset/104762>