Summary: | Compilation errors on build-webkit --debug --no-workers on mac. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pablo Flouret <pf> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Minor | CC: | abarth, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.6 | ||||||
Attachments: |
|
Description
Pablo Flouret
2012-01-09 10:56:00 PST
Created attachment 121691 [details]
proposed patch
Comment on attachment 121691 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=121691&action=review > Source/WebKit/mac/Workers/WebWorkersPrivate.mm:39 > -#if ENABLE_WORKERS > +#if defined(ENABLE_WORKERS) && ENABLE_WORKERS We can't used ENABLE(WORKERS) here? Comment on attachment 121691 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=121691&action=review >> Source/WebKit/mac/Workers/WebWorkersPrivate.mm:39 >> +#if defined(ENABLE_WORKERS) && ENABLE_WORKERS > > We can't used ENABLE(WORKERS) here? Doesn't include config.h, i think. Comment on attachment 121691 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=121691&action=review >>> Source/WebKit/mac/Workers/WebWorkersPrivate.mm:39 >>> +#if defined(ENABLE_WORKERS) && ENABLE_WORKERS >> >> We can't used ENABLE(WORKERS) here? > > Doesn't include config.h, i think. Crazy Comment on attachment 121691 [details] proposed patch Rejecting attachment 121691 [details] from commit-queue. New failing tests: media/audio-garbage-collect.html Full output: http://queues.webkit.org/results/11264467 Test failure looks unrelated. Comment on attachment 121691 [details]
proposed patch
Yeah, sorry. That test was flaky for a while.
Comment on attachment 121691 [details] proposed patch Clearing flags on attachment: 121691 Committed r106342: <http://trac.webkit.org/changeset/106342> All reviewed patches have been landed. Closing bug. |