Summary: | Compilation errors on build-webkit --debug --no-video --no-fullscreen-api on mac. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pablo Flouret <pf> | ||||||||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Minor | CC: | eric.carlson, gustavo, pnormand, webkit.review.bot, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | OS X 10.6 | ||||||||||||
Attachments: |
|
Description
Pablo Flouret
2012-01-09 10:48:00 PST
Created attachment 121686 [details]
proposed patch
Comment on attachment 121686 [details] proposed patch Attachment 121686 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11184590 Created attachment 121701 [details]
don't enable video-track on gtk or blackberry by default
Comment on attachment 121701 [details] don't enable video-track on gtk or blackberry by default View in context: https://bugs.webkit.org/attachment.cgi?id=121701&action=review > Source/JavaScriptCore/wtf/Platform.h:546 > +#if defined(ENABLE_VIDEO) > +#define ENABLE_FULLSCREEN_API 1 This is wrong I think. The FullScreen API allows about any HTML element to request full screen display. What errors do you get exactly? My bad, i thought fullscreen depended on video since i usually heard mention of it in that context, i'll just fix the --no-video issues in this bug. Created attachment 121911 [details]
leave out --no-fullscreen issues.
Comment on attachment 121911 [details] leave out --no-fullscreen issues. View in context: https://bugs.webkit.org/attachment.cgi?id=121911&action=review Can you please elaborate the ChangeLog entries instead of copy/pasting the same message? > Source/WebCore/rendering/RenderThemeMac.h:176 > -#endif > - > virtual bool shouldShowPlaceholderWhenFocused() const; > +#endif I might be wrong here, but I think this method was added under the wrong guard in the first place. It's used only in the HTMLTextFormControlElement from what I can tell, which has nothing to do with VIDEO. > Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:947 > +void WebChromeClient::fullScreenRendererChanged(RenderBox* renderer) This method should not be under VIDEO, it is guarded by FULLSCREEN_API in ChromeClient.h. Created attachment 122453 [details]
fixes from review comments
Comment on attachment 122453 [details] fixes from review comments Clearing flags on attachment: 122453 Committed r105032: <http://trac.webkit.org/changeset/105032> All reviewed patches have been landed. Closing bug. |