Bug 75771

Summary: Valid canonical URLs should have a lowercase hostname
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: WebCore Misc.Assignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, darin, ddkilzer, eric, jberlin, mjs, sam, timothy, webkit.review.bot
Priority: P2 Keywords: EasyFix
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2012-01-06 23:21:46 PST
See http://tools.ietf.org/html/rfc3986#page-18
Attachments
Patch (15.60 KB, patch)
2012-01-06 23:29 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (24.43 KB, patch)
2012-01-08 14:51 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-01-06 23:29:00 PST
Created attachment 121540 [details] Patch
Adam Barth
Comment 2 2012-01-06 23:37:34 PST
Comment on attachment 121540 [details] Patch You would think this patch would be correct, but it will break Safari Extensions because the safari-extension URI scheme has a case sensitive authority, in violation of the URI RFCs.
Timothy Hatcher
Comment 3 2012-01-07 07:33:03 PST
Déjà vu, see bug 53848 and bug 54318. I could have sworn Eric went on to make a change that only lowercased hosts in schemes that we know are correct to do so (http, https, ftp, etc.) But I am not finding such a change or bug.
Timothy Hatcher
Comment 4 2012-01-07 07:37:36 PST
Ah, I was looking at scheme bugs not host bugs. I found the right ones with the past discussions. Bug 54271.
Timothy Hatcher
Comment 5 2012-01-07 07:40:29 PST
Comment on attachment 121540 [details] Patch r- since this is known to break Safari Extensions.
Timothy Hatcher
Comment 6 2012-01-07 07:43:46 PST
Oh and bug 54084 was the original change.
Benjamin Poulain
Comment 7 2012-01-07 12:27:54 PST
Reading the past discussions about this, how do you feel about lowercasing only for the following schemes: "http", "https", "ftp", "ws", "wss", "gopher"? It seems that is the only subset for which everyone agreed about lowercasing the authority :) (+add a test for Safari Extensions URLs)
Timothy Hatcher
Comment 8 2012-01-07 12:33:56 PST
file URLs have a host sometimes, so they should be included.
Benjamin Poulain
Comment 9 2012-01-08 14:51:06 PST
Created attachment 121591 [details] Patch
WebKit Review Bot
Comment 10 2012-01-08 15:44:59 PST
Comment on attachment 121591 [details] Patch Clearing flags on attachment: 121591 Committed r104414: <http://trac.webkit.org/changeset/104414>
WebKit Review Bot
Comment 11 2012-01-08 15:45:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.