Bug 75754

Summary: [Qt] build failure in jit/JIT.h
Product: WebKit Reporter: Pavel Heimlich (hajma) <tropikhajma>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: andersca, barraclough, hausmann, laszlo.gombos
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch morrita: review-

Pavel Heimlich (hajma)
Reported 2012-01-06 15:58:21 PST
when building qt 4.8 with Solaris Studio, the build fails inside the included webkit, as below The attached patch fixes that for me, although I don't really speak c++ so I may be horribly wrong /opt/test2/SolarisStudio12.3-solaris-x86-bin/solarisstudio12.3/bin/CC -c -I../../../../../mkspecs/solaris-cc -I. -I../../../../../include/QtCore -I../../../../../include -I. -I../../Source -I../ThirdParty -Iassembler -Ibytecode -Ibytecompiler -Iheap -Idfg -Idebugger -Iinterpreter -Ijit -Iparser -Iprofiler -Iruntime -Iwtf -Iwtf/gobject -I/opt/test2/packages/BUILD/qt-4.8.0/i386/qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/JavaScriptCore/wtf/symbian -Iwtf/unicode -Iyarr -IAPI -IForwardingHeaders -Igenerated -I../../Source -I../../include -I/include/QtWebKit -I/include -I.moc/debug-static -I/usr/sfw/include -D_REENTRANT -DNDEBUG -D__EXTENSIONS__ -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_POSIX_PTHREAD_SEMANTICS -DSOLARIS -DNO_DEBUG -D_UNICODE -DUNICODE -D_RWSTD_REENTRANT -D_XOPEN_SOURCE=500 -D_XPG5 -I/opt/kde4/include -m32 -xarch=sse2 -features=extensions,nestedaccess,tmplrefstatic -template=geninlinefuncs -s -xlang=c99 -xustr=ascii_utf16_ushort -Qoption ccfe -features=gcc -Qoption ccfe -features=zla -Qoption ccfe ++boolflag:sunwcch=false -R/opt/kde4/lib -library=stdcxx4 -lCrun -I/usr/include/libpng14 -I/opt/kde4/include -I/usr/mysql/5.1/include/mysql -I/usr/include/libmng -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/odbc -KPIC -mt -DNDEBUG -DBUILDING_QT__=1 -DQT_ASCII_CAST_WARNINGS -DBUILDING_JavaScriptCore -DBUILDING_WTF -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_CORE_LIB -DQT_HAVE_MMX -DQT_HAVE_SSE -DQT_HAVE_MMXEXT -DQT_HAVE_SSE2 -DQT_HAVE_SSE3 -DQT_SHARED -o .obj/debug-static/CodeBlock.o bytecode/CodeBlock.cpp "./wtf/OSAllocator.h", line 43: Warning: Identifier expected instead of "}". ... "jit/JIT.h", line 253: Error: JSC::AbstractMacroAssembler<JSC::X86Assembler>::Label is not accessible from JSC::JIT::JSRInfo. "jit/JIT.h", line 255: Error: JSC::AbstractMacroAssembler<JSC::X86Assembler>::Label is not accessible from JSC::JIT::JSRInfo. ... 2 Error(s) and 36 Warning(s) detected. gmake: *** [.obj/debug-static/CodeBlock.o] Error 2 This is on Solaris 11 using Solaris Studio 12.3
Attachments
Patch (1.26 KB, patch)
2012-01-06 16:06 PST, Pavel Heimlich (hajma) 		morrita: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Heimlich (hajma)
Comment 1 2012-01-06 16:06:50 PST
Created attachment 121514 [details] Patch
Hajime Morrita
Comment 2 2012-01-16 01:44:10 PST
Comment on attachment 121514 [details] Patch Looking around the code, having a using clause looks more popular when the class has several Label usage. Also, I guess it will prevent future build breaks.
Simon Hausmann
Comment 3 2012-09-19 00:59:47 PDT
The code in question doesn't exist anymore.
Note You need to log in before you can comment on or make changes to this bug.