Bug 75733

Summary:

build failure in wtf/ByteArray.cpp

Product:

WebKit

Reporter:

Pavel Heimlich (hajma) <tropikhajma>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Other

Attachments:

Description	Flags
Patch	none

Pavel Heimlich (hajma)

Reported 2012-01-06 13:01:14 PST

building Qt 4.8 fails with the below error. This is because Solaris Studio is stricter about the C++ standard than gcc. Adding Solaris Studio to the already existing ifdef for MSVC makes this go away. test2@solaris:~/packages/BUILD/qt-4.8.0/i386/qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/JavaScriptCore$ /opt/test2/SolarisStudio12.3-solaris-x86-bin/solarisstudio12.3/bin/CC -c -I../../../../../mkspecs/solaris-cc -I. -I../../../../../include/QtCore -I../../../../../include -I. -I../../Source -I../ThirdParty -Iassembler -Ibytecode -Ibytecompiler -Iheap -Idfg -Idebugger -Iinterpreter -Ijit -Iparser -Iprofiler -Iruntime -Iwtf -Iwtf/gobject -I/opt/test2/packages/BUILD/qt-4.8.0/i386/qt-everywhere-opensource-src-4.8.0/src/3rdparty/webkit/Source/JavaScriptCore/wtf/symbian -Iwtf/unicode -Iyarr -IAPI -IForwardingHeaders -Igenerated -I../../Source -I../../include -I/include/QtWebKit -I/include -I.moc/debug-static -I/usr/sfw/include -D_REENTRANT -DNDEBUG -D__EXTENSIONS__ -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_POSIX_PTHREAD_SEMANTICS -DSOLARIS -DNO_DEBUG -D_UNICODE -DUNICODE -D_RWSTD_REENTRANT -D_XOPEN_SOURCE=500 -D_XPG5 -I/opt/kde4/include -m32 -xarch=sse2 -features=extensions,nestedaccess,tmplrefstatic -template=geninlinefuncs -s -xlang=c99 -xustr=ascii_utf16_ushort -Qoption ccfe -features=gcc -Qoption ccfe -features=zla -Qoption ccfe ++boolflag:sunwcch=false -R/opt/kde4/lib -library=stdcxx4 -lCrun -I/usr/include/libpng14 -I/opt/kde4/include -I/usr/mysql/5.1/include/mysql -I/usr/include/libmng -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/odbc -KPIC -mt -DNDEBUG -DBUILDING_QT__=1 -DQT_ASCII_CAST_WARNINGS -DBUILDING_JavaScriptCore -DBUILDING_WTF -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_CORE_LIB -DQT_HAVE_MMX -DQT_HAVE_SSE -DQT_HAVE_MMXEXT -DQT_HAVE_SSE2 -DQT_HAVE_SSE3 -DQT_SHARED -o .obj/debug-static/ByteArray.o wtf/ByteArray.cpp "wtf/ByteArray.h", line 97: Error: In this declaration "m_data" is of an incomplete type "unsigned char[]". 1 Error(s) detected. This is on Solaris 11 using Solaris Studio 12.3

Attachments
Patch (1.16 KB, patch) 2012-01-06 13:09 PST, Pavel Heimlich (hajma)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Heimlich (hajma)

Comment 1 2012-01-06 13:09:59 PST

Created attachment 121479 [details] Patch

Alexey Proskuryakov

Comment 2 2012-01-09 10:30:41 PST

Comment on attachment 121479 [details] Patch I assume that you want this landed. In the future, please mark patches with cq? to make the intention clear.

WebKit Review Bot

Comment 3 2012-01-09 11:44:52 PST

Comment on attachment 121479 [details] Patch Clearing flags on attachment: 121479 Committed r104471: <http://trac.webkit.org/changeset/104471>

WebKit Review Bot

Comment 4 2012-01-09 11:44:56 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.