Bug 75658

Summary:

Enable a compositing trigger for filters

Product:

WebKit

Reporter:

Noam Rosenthal <noam>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achicu, cmarrin, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+
Patch	none

Description Noam Rosenthal 2012-01-05 15:22:14 PST

For Qt, we would like an option to force the compositing path for filters, and the right place to do so seems to be RenderLayerCompositor and the triggers in ChromeClient.

Comment 1 Noam Rosenthal 2012-01-05 15:32:04 PST

Created attachment 121349 [details]
Patch

Comment 2 Noam Rosenthal 2012-01-06 14:07:54 PST

Created attachment 121492 [details]
Patch

Comment 3 WebKit Review Bot 2012-01-06 15:13:18 PST

Comment on attachment 121492 [details]
Patch

Clearing flags on attachment: 121492

Committed r104347: <http://trac.webkit.org/changeset/104347>

Comment 4 WebKit Review Bot 2012-01-06 15:13:22 PST

All reviewed patches have been landed.  Closing bug.

Comment 5 Alexandru Chiculita 2012-01-09 04:23:54 PST

This patch broke the cases when some of the filters do not render in composited mode. That's because RenderLayerBacking::paintIntoLayer has no logic for applying filters yet. I've added https://bugs.webkit.org/show_bug.cgi?id=75842 to fix that.