| Summary: | [Chromium] Do not recreate texture updater for image layer if one exists. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Sievers <sievers> | ||||||||||
| Component: | New Bugs | Assignee: | Daniel Sievers <sievers> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cc-bugs, dglazkov, enne, jamesr, shawnsingh, vangelis, webkit.review.bot | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Daniel Sievers
2012-01-04 17:21:08 PST
Created attachment 121190 [details]
Patch
Comment on attachment 121190 [details]
Patch
Any way to test this? Perhaps a layout test that shows the image corruption?
Created attachment 121502 [details]
Patch
I had no luck with reparenting through JavaScript, because it ended up creating a new ImageLayer in that case, which doesn't show the bug. See attached patch, growing the layer (which inserts the scrollbar layer) however shows the problem. The initial layoutController.display() before changing the layer size seems to be necessary also to make it fail. Not sure if that is the right directory for the resource .jpg. I copied it from the top-level compositing/resources dir, although I saw another test reference it from the platform dir relatively, but when I ran new-run-webkit-tests that wouldn't work to find it. (In reply to comment #2) > (From update of attachment 121190 [details]) > Any way to test this? Perhaps a layout test that shows the image corruption? Comment on attachment 121502 [details] Patch Attachment 121502 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11170117 New failing tests: platform/chromium/compositing/img-layer-grow.html Created attachment 121523 [details]
Patch
You should not need to copy any resources, a relative include should work fine. Are you sure you got the path right? Please use mock scrollbars or css-style them if they are going to be in the visible test output. add a layoutTestController.dumpAsText(true) to suppress the normal render tree output, it's not needed for this test. Created attachment 121721 [details]
Patch
Comment on attachment 121721 [details]
Patch
Nice, R=me
James, can you cq+? Thanks! (In reply to comment #9) > (From update of attachment 121721 [details]) > Nice, R=me Comment on attachment 121721 [details]
Patch
Sure. In the future you can request this by setting the commit-queue flag to "?" or by running webkit-patch upload --request-commit
Comment on attachment 121721 [details] Patch Clearing flags on attachment: 121721 Committed r104610: <http://trac.webkit.org/changeset/104610> All reviewed patches have been landed. Closing bug. *** Bug 76185 has been marked as a duplicate of this bug. *** |