Bug 75559

Summary: Move Gamepad declarations from Navigator.idl into Modules/gamepad
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken, ojan, scottmg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Barth
Reported 2012-01-04 10:18:21 PST
Move Gamepad declarations from Navigator.idl into Modules/gamepad
Attachments
Patch (9.23 KB, patch)
2012-01-04 10:19 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.23 KB, patch)
2012-01-04 12:03 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-01-04 10:19:22 PST
Created attachment 121121 [details] Patch
Eric Seidel (no email)
Comment 2 2012-01-04 11:43:13 PST
Comment on attachment 121121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121121&action=review > Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp:45 > + // FIXME: We shouldn't need direct this call to Navigator. I think you're missing a "to" here. I assume this is just a baby-step and you plan to move the code out of navigator.cpp in a second patch...
Adam Barth
Comment 3 2012-01-04 12:01:46 PST
> I assume this is just a baby-step and you plan to move the code out of navigator.cpp in a second patch... Yep.
Adam Barth
Comment 4 2012-01-04 12:03:49 PST
Created attachment 121134 [details] Patch for landing
WebKit Review Bot
Comment 5 2012-01-05 05:27:57 PST
Comment on attachment 121134 [details] Patch for landing Clearing flags on attachment: 121134 Committed r104146: <http://trac.webkit.org/changeset/104146>
WebKit Review Bot
Comment 6 2012-01-05 05:28:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.