Summary: | REGRESSION (r103519): WebCore's DerivedSources.make crashes sh.exe if path to WebKit source tree is long enough | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, haraken, jberlin, sfalken, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2012-01-04 07:18:08 PST
One option is to make all the commands separate statements: echo foo > ./idl_files.tmp; echo bar > ./idl_files.tmp; echo baz > ./idl_files.tmp;… This has the disadvantage of opening/closing idl_files.tmp over and over. Maybe a better solution would be to use printf(1). Created attachment 121108 [details]
Use one big printf command instead of many chained echo commands to generate idl_files.tmp
I am sorry for the regression. The change looks OK to me. Just a comment: (In reply to comment #2) > One option is to make all the commands separate statements: > > echo foo > ./idl_files.tmp; echo bar > ./idl_files.tmp; echo baz > ./idl_files.tmp;… I avoided this approach because it took 10~ seconds on my local AppleWebKit environment. > This has the disadvantage of opening/closing idl_files.tmp over and over. > > Maybe a better solution would be to use printf(1). I avoided an echo command with long arguments because it can exceed the OS limit. Is the printf command OK? Committed r104038: <http://trac.webkit.org/changeset/104038> (In reply to comment #4) > (In reply to comment #2) > > Maybe a better solution would be to use printf(1). > > I avoided an echo command with long arguments because it can exceed the OS limit. Is the printf command OK? It seems to work fine on my Windows and OS X machines. I guess we'll see if the bots notice any problems. |