Bug 75524

Summary:

prepare-ChangeLog cannot parse python code that nests classes and defs

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

Tools / Tests

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, ddkilzer, rniwa, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

73531

Attachments:

Description	Flags
Patch	none

Kentaro Hara

Reported 2012-01-03 21:56:42 PST

The python parser of prepare-ChangeLog cannot correctly parse python code that nests classes and defs, like this: class C: pass def f(): pass pass

Attachments
Patch (5.59 KB, patch) 2012-01-03 22:15 PST, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-01-03 22:15:50 PST

Created attachment 121066 [details] Patch

Kentaro Hara

Comment 2 2012-01-03 23:10:56 PST

Comment on attachment 121066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121066&action=review > Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:4 > + '23', This should be 21, but 23 is also acceptable because including extra empty lines into @ranges does not at all affect the prepare-ChangeLog output. (Even if fixing this issue were necessary, I'd like to fix it in another patch as it requires non-trivial code change.) 21 def func1(): 22 23 24 def func2(): 25 ....

Ryosuke Niwa

Comment 3 2012-01-04 10:19:48 PST

Comment on attachment 121066 [details] Patch looks sane to me

WebKit Review Bot

Comment 4 2012-01-05 02:56:21 PST

Comment on attachment 121066 [details] Patch Clearing flags on attachment: 121066 Committed r104132: <http://trac.webkit.org/changeset/104132>

WebKit Review Bot

Comment 5 2012-01-05 02:56:26 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.