Bug 75492 – [chromium] Fix compilation with clang and the shared build

• Component: New Bugs
• Status: RESOLVED FIXED

[Tony Chang]

[chromium] Fix compilation with clang and the shared build

[Tony Chang]

Created attachment 120990 [details]
Patch

[Tony Chang]

The clang+components build still fails for me at link time with:

/usr/local/gold/bin/ld: obj/gpu/command_buffer_service.a(obj/gpu/command_buffer/service/command_buffer_service.feature_info.o): in function gpu::gles2::FeatureInfo::AddFeatures(char const*):../../gpu/command_buffer/service/feature_info.cc(.text._ZN3gpu5gles211FeatureInfo11AddFeaturesEPKc+0x2db4): error: undefined reference to 'base::internal::StringPieceDetail<std::string>::npos'

But this gets us closer.

[Nico Weber]

Comment on attachment 120990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120990&action=review

lgtm

> Source/WebKit/chromium/WebKit.gyp:751
> +                                    # but the test files have global constructors from the GTEST macro.

maybe mention somehow that that's because we pull in test files into the main webkit target for the shared build

[Ami Fischman]

(In reply to comment #2)
> The clang+components build still fails for me at link time with:
> 
> /usr/local/gold/bin/ld: obj/gpu/command_buffer_service.a(obj/gpu/command_buffer/service/command_buffer_service.feature_info.o): in function gpu::gles2::FeatureInfo::AddFeatures(char const*):../../gpu/command_buffer/service/feature_info.cc(.text._ZN3gpu5gles211FeatureInfo11AddFeaturesEPKc+0x2db4): error: undefined reference to 'base::internal::StringPieceDetail<std::string>::npos'
> 
> But this gets us closer.

Are you at clang r147441 or later?  
I didn't need to hack StringPiece to link chrome (only needed to change base/{logging,string16}.h), although I did have to hack at StringPiece with an earlier clang rev.

FTR, the clang-side bug is http://llvm.org/bugs/show_bug.cgi?id=11690 and the chromium-side bug is http://code.google.com/p/chromium/issues/detail?id=97532

[Tony Chang]

Created attachment 120997 [details]
Patch

[Tony Chang]

(In reply to comment #3)
> (From update of attachment 120990 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=120990&action=review
> 
> > Source/WebKit/chromium/WebKit.gyp:751
> > +                                    # but the test files have global constructors from the GTEST macro.
> 
> maybe mention somehow that that's because we pull in test files into the main webkit target for the shared build

Done.

(In reply to comment #4)
> Are you at clang r147441 or later?  

Ah, I'm not. That would probably fix it.

Thanks!

[Nico Weber]

Comment on attachment 120997 [details]
Patch

LGTM, thanks!

[Tony Chang]

Committed r103980: <http://trac.webkit.org/changeset/103980>