Bug 75482

Summary:

Move HTMLFormControlElementWithState class in its own header file.

Product:

WebKit

Reporter:

Alexis Menard (darktears) <menard>

Component:

DOM

Assignee:

Alexis Menard (darktears) <menard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, kling, ossy, rakuco, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

75689

Bug Blocks:

Attachments:

Description	Flags
Patch	tkent: review-
Patch	tkent: review-, tkent: commit-queue-
Patch V3	none
Patch V3	none

Alexis Menard (darktears)

Reported 2012-01-03 11:21:56 PST

Move HTMLFormControlElementWithState class in its own header file.

Attachments
Patch (164.02 KB, patch) 2012-01-03 11:25 PST, Alexis Menard (darktears)	tkent: review-	Details Formatted Diff Diff
Patch (20.81 KB, patch) 2012-01-05 03:45 PST, Alexis Menard (darktears)	tkent: review- tkent: commit-queue-	Details Formatted Diff Diff
Patch V3 (31.43 KB, patch) 2012-01-05 05:29 PST, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Patch V3 (21.84 KB, patch) 2012-01-05 06:17 PST, Alexis Menard (darktears)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alexis Menard (darktears)

Comment 1 2012-01-03 11:25:25 PST

Created attachment 120970 [details] Patch

Kent Tamura

Comment 2 2012-01-04 20:26:04 PST

Comment on attachment 120970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120970&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:14638 > - 7AA51B6D1483B61600AD2752 /* InspectorBaseAgent.cpp */, > 7AA51B6C1483B61600AD2752 /* InspectorBaseAgent.h */, > + 7AA51B6D1483B61600AD2752 /* InspectorBaseAgent.cpp */, Please do not reorder unrelated files in this patch. Such patch often makes conflicts as you see on Qt EWS.

Alexis Menard (darktears)

Comment 3 2012-01-05 03:45:51 PST

Created attachment 121253 [details] Patch New version. Sounds like if I upload the patch with webkit-patch it sorts the Xcode file.

Kent Tamura

Comment 4 2012-01-05 04:40:27 PST

Comment on attachment 121253 [details] Patch We need to update html/HTMLElementsAllInOne.cpp.

Kent Tamura

Comment 5 2012-01-05 04:42:30 PST

Comment on attachment 121253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121253&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:17218 > + E14F1C3214B5C1CC00EA9009 /* HTMLFormControlElementWithState.cpp */, > + E14F1C3314B5C1CC00EA9009 /* HTMLFormControlElementWithState.h */, > 49484FAE102CF01E00187DD3 /* canvas */, Please insert these new lines to sorted position. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:24968 > FD537353137B651800008DCE /* ZeroPole.h in Headers */, > + E14F1C3514B5C1CC00EA9009 /* HTMLFormControlElementWithState.h in Headers */, ditto. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:27872 > FD537352137B651800008DCE /* ZeroPole.cpp in Sources */, > + E14F1C3414B5C1CC00EA9009 /* HTMLFormControlElementWithState.cpp in Sources */, ditto.

Andreas Kling

Comment 6 2012-01-05 04:50:40 PST

(In reply to comment #4) > (From update of attachment 121253 [details]) > We need to update html/HTMLElementsAllInOne.cpp. Ratcakes! I always forget about those, sorry.

Alexis Menard (darktears)

Comment 7 2012-01-05 05:29:40 PST

Created attachment 121265 [details] Patch V3 I hope I got it right this time :(.

Alexis Menard (darktears)

Comment 8 2012-01-05 06:17:50 PST

Created attachment 121269 [details] Patch V3 Should be the right one now.

Kent Tamura

Comment 9 2012-01-05 17:53:34 PST

Comment on attachment 121269 [details] Patch V3 Great. Thanks!

WebKit Review Bot

Comment 10 2012-01-05 21:36:54 PST

Comment on attachment 121269 [details] Patch V3 Clearing flags on attachment: 121269 Committed r104268: <http://trac.webkit.org/changeset/104268>

WebKit Review Bot

Comment 11 2012-01-05 21:36:59 PST

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 12 2012-01-06 00:11:00 PST

Reopen, because it was rolled out (it broke the Mac build): http://trac.webkit.org/changeset/104272

Kent Tamura

Comment 13 2012-01-06 00:33:41 PST

Committed r104274: <http://trac.webkit.org/changeset/104274>

Kent Tamura

Comment 14 2012-01-06 00:35:34 PST

(In reply to comment #13) > Committed r104274: <http://trac.webkit.org/changeset/104274> I added settings = {ATTRIBUTES = (Private, ); }; for HTMLFormControlElementWithState.h in project.pbxproj.

Alexis Menard (darktears)

Comment 15 2012-01-06 03:55:02 PST

(In reply to comment #14) > (In reply to comment #13) > > Committed r104274: <http://trac.webkit.org/changeset/104274> > > I added > settings = {ATTRIBUTES = (Private, ); }; > for HTMLFormControlElementWithState.h in project.pbxproj. Sorry for the trouble.

Note You need to log in before you can comment on or make changes to this bug.