Summary: | REGRESSION (r102161): NRWT crashes on launch on Windows 7 SP1 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, eric, ojan, webkit-bug-importer, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 38756 | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2012-01-03 10:57:01 PST
Looks like WinPort.__init__ is setting self._operating_system before calling up to the super class, but Port.__init__ overwrites it. Created attachment 120972 [details]
Make Port subclasses override the operating_system method rather than setting an attribute
Comment on attachment 120972 [details]
Make Port subclasses override the operating_system method rather than setting an attribute
OK.
Comment on attachment 120972 [details] Make Port subclasses override the operating_system method rather than setting an attribute View in context: https://bugs.webkit.org/attachment.cgi?id=120972&action=review > Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py:108 > + def test_operating_system(self): > + self.assertEqual('win', self.make_port().operating_system()) This test would have failed before your patch, right? The most important bit of this change is the test. :) Comment on attachment 120972 [details] Make Port subclasses override the operating_system method rather than setting an attribute View in context: https://bugs.webkit.org/attachment.cgi?id=120972&action=review >> Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py:108 >> + self.assertEqual('win', self.make_port().operating_system()) > > This test would have failed before your patch, right? The most important bit of this change is the test. :) Exactly! I tested that it fails without my patch. Committed r103952: <http://trac.webkit.org/changeset/103952> |