Bug 75476
| Summary: | PLATFORM(MAC) should not be defined when building PLATFORM(IOS) and PLATFORM(IOS_SIMULATOR) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aroben, benjamin, joepeck, mitz, mjs, psolanki, sam, yongjun_zhang |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Kilzer (:ddkilzer)
* SUMMARY
After a discussion with Dan Bernstein, we felt that it would be much more work to NOT define PLATFORM(MAC) when building PLATFORM(IOS) and PLATFORM(IOS_SIMULATOR) since they share so much code. If that ever changes in the future, we can always revisit this decision.
This bug is to define WTF_PLATFORM_MAC to 1 when building PLATFORM(IOS) and PLATFORM(IOS_SIMULATOR).
* NOTES
See also: <rdar://problem/6298943&6298944&6298945&6298946>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
Dan Bernstein fixed this in a variety of commits, including (but not limited to):
<http://trac.webkit.org/r163288>
<http://trac.webkit.org/r163291>
<http://trac.webkit.org/r163657>
<http://trac.webkit.org/r163725>
<http://trac.webkit.org/r163731>
<http://trac.webkit.org/r164192>
<http://trac.webkit.org/r164270>
Most of the other fixes where in Source/WebKit2 (and other test code in r164295), but aren't listed here.