| Summary: | ES5 prohibits parseInt from supporting octal | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
| Component: | JavaScriptCore | Assignee: | Gavin Barraclough <barraclough> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dglazkov, ossy, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 75468 | ||||||
| Attachments: |
|
||||||
|
Description
Gavin Barraclough
2012-01-02 18:23:40 PST
Created attachment 120905 [details]
Fix
Attachment 120905 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:274: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:277: Should have a space between // and comment [whitespace/comments] [4]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 120905 [details] Fix Attachment 120905 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11003149 New failing tests: fast/js/kde/GlobalObject.html Comment on attachment 120905 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=120905&action=review >> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:277 >> + // 8.a. If R < 2 or R > 36, then return NaN. > > Should have a space between // and comment [whitespace/comments] [4] There seems to be a weird character in your comment. (In reply to comment #4) > There seems to be a weird character in your comment. Ooops, yes! (copied & pasted from spec!) fixed. Fixed in r103922. (The change in layout test results for Chromium represents a bug in the v8 engine). Reopen, because it broke 2 jscore tests on all bot: ecma/GlobalObject/15.1.2.2-1.js ecma/GlobalObject/15.1.2.2-2.js Could you fix it, please? (In reply to comment #6) > Reopen, because it broke 2 jscore tests on all bot: > ecma/GlobalObject/15.1.2.2-1.js > ecma/GlobalObject/15.1.2.2-2.js > > Could you fix it, please? Ooops, sorry! - fixes for the tests are incoming! |