Bug 75447 – Ambiguous if-then-else in Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Bill Wendling]

Clang discovered an ambiguous if-then-else in Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm. Here's the code (around line 254):


    if (archive)
        if ([types containsObject:WebArchivePboardType])
            [self setData:[archive data] forType:WebArchivePboardType];
    else {
        // We should not have declared types that we aren't going to write (4031826).
        ASSERT(![types containsObject:NSRTFDPboardType]);
        ASSERT(![types containsObject:WebArchivePboardType]);
    }

Clang suggests adding explicit braces. Indeed, the indenting suggests that the code should be different from what it is.

[Alexey Proskuryakov]

This was introduced in <http://trac.webkit.org/changeset/21533>. No release build impact though, as it's only assertions.

How did clang discover this? Did you use static analyzer, or different warnings flags with a regular build?

[Bill Wendling]

I was using ToT clang and doing a normal build. I believe it's a new warning flag that's on by default.

[Anders Carlsson]

Created attachment 121145 [details]
Patch

[Anders Carlsson]

Committed r104066: <http://trac.webkit.org/changeset/104066>