Bug 75413

Summary:

Enable the [Supplemental] IDL on BlackBerry

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

WebKit Misc.

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, efidler, mxie, rakuco, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

72138

Attachments:

Description	Flags
WIP patch to see if build passes	haraken: commit-queue-
Patch	none

Kentaro Hara

Reported 2011-12-31 16:57:56 PST

We have enabled the [Supplemental] IDL on Chromium, AppleWebKit, GTK, Qt, Efl and WinCE, and are planning to enable it on all platforms (Meta bug 72138). In this bug, we enable it on BlackBerry.

Attachments
WIP patch to see if build passes (4.44 KB, patch) 2012-01-01 08:01 PST, Kentaro Hara	haraken: commit-queue-	Details Formatted Diff Diff
Patch (4.42 KB, patch) 2012-04-11 09:44 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2012-01-01 08:01:26 PST

Created attachment 120845 [details] WIP patch to see if build passes

Kentaro Hara

Comment 2 2012-01-01 08:04:31 PST

rwlbuis, tonikitoo: I uploaded a patch, but unfortunately I do not have a build environment for BlackBerry. If possible, would you please confirm that my patch passes the BlackBerry build?

Antonio Gomes

Comment 3 2012-01-02 08:30:04 PST

Ming, would you mind to help out Kentaro? Thanks

Rob Buis

Comment 4 2012-04-11 09:05:39 PDT

Comment on attachment 120845 [details] WIP patch to see if build passes View in context: https://bugs.webkit.org/attachment.cgi?id=120845&action=review Looks good. This patch went under my radar, sorry :) > Source/WebCore/ChangeLog:32 > + http/tests/websocket/tests/* Is this last line valid?

Kentaro Hara

Comment 5 2012-04-11 09:26:47 PDT

Comment on attachment 120845 [details] WIP patch to see if build passes View in context: https://bugs.webkit.org/attachment.cgi?id=120845&action=review >> Source/WebCore/ChangeLog:32 >> + http/tests/websocket/tests/* > > Is this last line valid? Valid. It means that all websocket tests will be affected by this change, since websocket is now using [Supplemental].

Rob Buis

Comment 6 2012-04-11 09:29:52 PDT

Hi, (In reply to comment #5) > (From update of attachment 120845 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120845&action=review > > >> Source/WebCore/ChangeLog:32 > >> + http/tests/websocket/tests/* > > > > Is this last line valid? > > Valid. It means that all websocket tests will be affected by this change, since websocket is now using [Supplemental]. Great, the patch is good to go! Thanks for helping us out :) Cheers, Rob.

Kentaro Hara

Comment 7 2012-04-11 09:32:20 PDT

Comment on attachment 120845 [details] WIP patch to see if build passes I've remembered that we renamed resolve-supplemental.pl to preprocess-idls.pl. The patch is coming...

Kentaro Hara

Comment 8 2012-04-11 09:44:13 PDT

Created attachment 136681 [details] Patch

WebKit Review Bot

Comment 9 2012-04-11 10:46:15 PDT

Comment on attachment 136681 [details] Patch Clearing flags on attachment: 136681 Committed r113878: <http://trac.webkit.org/changeset/113878>

Note You need to log in before you can comment on or make changes to this bug.