Summary: | QuerySelector should not have side effect. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shinya Kawanaka <shinyak> | ||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kling, koivisto, shinyak, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Shinya Kawanaka
2011-12-28 01:19:54 PST
Created attachment 120643 [details]
Patch
Comment on attachment 120643 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120643&action=review > Source/WebCore/ChangeLog:11 > + No new tests. Covered by existing tests. If this is covered by existing tests, why aren't you unskipping something that used to fail? (In reply to comment #2) > If this is covered by existing tests, why aren't you unskipping something that used to fail? The flags that these end up setting affect style recalc performance optimizations and are not easily testable. Selector queries itself should should have reasonable coverage. Comment on attachment 120643 [details] Patch Clearing flags on attachment: 120643 Committed r104793: <http://trac.webkit.org/changeset/104793> All reviewed patches have been landed. Closing bug. |