Bug 75284

Summary:

Web Inspector: CodeGeneratorInspector.py: generate array types.

Product:

WebKit

Reporter:

Peter Rybin <peter.rybin>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, ossy, peter.rybin, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

76188

Bug Blocks:

72861

Attachments:

Description	Flags
Patch	none
InspectorFrontend.h base version	none
New InspectorFrontend.h	none
Generator output diff	none
Rebasing	none
Patch	none
InspectorFrontend.h base version	none
New InspectorFrontend.h	none
Generator output diff	none
Patch	none
Patch	none

Description Peter Rybin 2011-12-27 17:59:12 PST

Generate array types in C++ TypeBuilder.
Each array will have its own type (i.e. not a template instantiation).

Comment 1 Peter Rybin 2012-01-11 08:20:06 PST

Created attachment 122029 [details]
Patch

Comment 2 Peter Rybin 2012-01-11 08:21:22 PST

Created attachment 122030 [details]
InspectorFrontend.h base version

Comment 3 Peter Rybin 2012-01-11 08:24:26 PST

Created attachment 122031 [details]
New InspectorFrontend.h

Comment 4 Peter Rybin 2012-01-11 08:25:22 PST

Created attachment 122032 [details]
Generator output diff

Comment 5 Yury Semikhatsky 2012-01-11 10:29:05 PST

Comment on attachment 122029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122029&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.py:929
> +                                                # fixed_type_name.output_comment(writer)

Remove commented code?

Comment 6 Peter Rybin 2012-01-11 10:41:43 PST

Created attachment 122050 [details]
Rebasing

Comment 7 Peter Rybin 2012-01-11 10:42:13 PST

> > Source/WebCore/inspector/CodeGeneratorInspector.py:929
> > +                                                # fixed_type_name.output_comment(writer)
> 
> Remove commented code?

Done

Comment 8 Peter Rybin 2012-01-12 05:20:07 PST

Created attachment 122219 [details]
Patch

Comment 9 Peter Rybin 2012-01-12 06:08:01 PST

Created attachment 122224 [details]
InspectorFrontend.h base version

Comment 10 Peter Rybin 2012-01-12 06:09:31 PST

Created attachment 122225 [details]
New InspectorFrontend.h

Comment 11 Peter Rybin 2012-01-12 06:10:33 PST

Created attachment 122226 [details]
Generator output diff

Comment 12 Yury Semikhatsky 2012-01-12 06:44:35 PST

Comment on attachment 122219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=122219&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.py:916
> +                            writer.newline("    %s() {}\n" % fixed_type_name.class_name)

style nit: in generated code there should be a space between {}

Comment 13 Peter Rybin 2012-01-12 07:02:29 PST

Created attachment 122234 [details]
Patch

Comment 14 Peter Rybin 2012-01-12 07:03:15 PST

> style nit: in generated code there should be a space between {}

Done

Comment 15 WebKit Review Bot 2012-01-12 08:40:23 PST

Comment on attachment 122234 [details]
Patch

Clearing flags on attachment: 122234

Committed r104829: <http://trac.webkit.org/changeset/104829>

Comment 16 WebKit Review Bot 2012-01-12 08:40:29 PST

All reviewed patches have been landed.  Closing bug.

Comment 17 Csaba Osztrogonác 2012-01-12 08:45:13 PST

Reopen, because it broke the minimal build. Could you fix it?

http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/40446/steps/compile-webkit/logs/stdio

Comment 18 Peter Rybin 2012-01-14 20:25:31 PST

Created attachment 122561 [details]
Patch

Comment 19 WebKit Review Bot 2012-01-16 05:44:31 PST

Comment on attachment 122561 [details]
Patch

Clearing flags on attachment: 122561

Committed r105060: <http://trac.webkit.org/changeset/105060>

Comment 20 WebKit Review Bot 2012-01-16 05:44:37 PST

All reviewed patches have been landed.  Closing bug.