Bug 75284

Summary:

Web Inspector: CodeGeneratorInspector.py: generate array types.

Product:

WebKit

Reporter:

Peter Rybin <peter.rybin>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, ossy, peter.rybin, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

76188

Bug Blocks:

72861

Attachments:

Description	Flags
Patch	none
InspectorFrontend.h base version	none
New InspectorFrontend.h	none
Generator output diff	none
Rebasing	none
Patch	none
InspectorFrontend.h base version	none
New InspectorFrontend.h	none
Generator output diff	none
Patch	none
Patch	none

Peter Rybin

Reported 2011-12-27 17:59:12 PST

Generate array types in C++ TypeBuilder. Each array will have its own type (i.e. not a template instantiation).

Attachments
Patch (9.66 KB, patch) 2012-01-11 08:20 PST, Peter Rybin	no flags	Details Formatted Diff Diff
InspectorFrontend.h base version (143.42 KB, text/plain) 2012-01-11 08:21 PST, Peter Rybin	no flags	Details
New InspectorFrontend.h (150.98 KB, text/plain) 2012-01-11 08:24 PST, Peter Rybin	no flags	Details
Generator output diff (18.76 KB, text/plain) 2012-01-11 08:25 PST, Peter Rybin	no flags	Details
Rebasing (9.39 KB, patch) 2012-01-11 10:41 PST, Peter Rybin	no flags	Details Formatted Diff Diff
Patch (10.91 KB, patch) 2012-01-12 05:20 PST, Peter Rybin	no flags	Details Formatted Diff Diff
InspectorFrontend.h base version (141.65 KB, text/plain) 2012-01-12 06:08 PST, Peter Rybin	no flags	Details
New InspectorFrontend.h (152.49 KB, text/plain) 2012-01-12 06:09 PST, Peter Rybin	no flags	Details
Generator output diff (22.34 KB, text/plain) 2012-01-12 06:10 PST, Peter Rybin	no flags	Details
Patch (10.91 KB, patch) 2012-01-12 07:02 PST, Peter Rybin	no flags	Details Formatted Diff Diff
Patch (12.31 KB, patch) 2012-01-14 20:25 PST, Peter Rybin	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Peter Rybin

Comment 1 2012-01-11 08:20:06 PST

Created attachment 122029 [details] Patch

Peter Rybin

Comment 2 2012-01-11 08:21:22 PST

Created attachment 122030 [details] InspectorFrontend.h base version

Peter Rybin

Comment 3 2012-01-11 08:24:26 PST

Created attachment 122031 [details] New InspectorFrontend.h

Peter Rybin

Comment 4 2012-01-11 08:25:22 PST

Created attachment 122032 [details] Generator output diff

Yury Semikhatsky

Comment 5 2012-01-11 10:29:05 PST

Comment on attachment 122029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122029&action=review > Source/WebCore/inspector/CodeGeneratorInspector.py:929 > + # fixed_type_name.output_comment(writer) Remove commented code?

Peter Rybin

Comment 6 2012-01-11 10:41:43 PST

Created attachment 122050 [details] Rebasing

Peter Rybin

Comment 7 2012-01-11 10:42:13 PST

> > Source/WebCore/inspector/CodeGeneratorInspector.py:929 > > + # fixed_type_name.output_comment(writer) > > Remove commented code? Done

Peter Rybin

Comment 8 2012-01-12 05:20:07 PST

Created attachment 122219 [details] Patch

Peter Rybin

Comment 9 2012-01-12 06:08:01 PST

Created attachment 122224 [details] InspectorFrontend.h base version

Peter Rybin

Comment 10 2012-01-12 06:09:31 PST

Created attachment 122225 [details] New InspectorFrontend.h

Peter Rybin

Comment 11 2012-01-12 06:10:33 PST

Created attachment 122226 [details] Generator output diff

Yury Semikhatsky

Comment 12 2012-01-12 06:44:35 PST

Comment on attachment 122219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122219&action=review > Source/WebCore/inspector/CodeGeneratorInspector.py:916 > + writer.newline(" %s() {}\n" % fixed_type_name.class_name) style nit: in generated code there should be a space between {}

Peter Rybin

Comment 13 2012-01-12 07:02:29 PST

Created attachment 122234 [details] Patch

Peter Rybin

Comment 14 2012-01-12 07:03:15 PST

> style nit: in generated code there should be a space between {} Done

WebKit Review Bot

Comment 15 2012-01-12 08:40:23 PST

Comment on attachment 122234 [details] Patch Clearing flags on attachment: 122234 Committed r104829: <http://trac.webkit.org/changeset/104829>

WebKit Review Bot

Comment 16 2012-01-12 08:40:29 PST

All reviewed patches have been landed. Closing bug.