Bug 75282
| Summary: | [Chromium] webkit-patch rebaseline-expectations doesn't support chromium-gpu-linux-x86_64 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Blocker | CC: | abarth, dpranke, eric, tony |
| Priority: | P1 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
It appears that webkit-patch rebaseline isn't pulling any results from chromium-gpu-linux-x86_64:
rniwa-macbookpro:webkit2 rniwa$ Tools/Scripts/webkit-patch rebaseline-expectations
Retrieving results for chromium-cg-mac-leopard from Webkit Mac10.5 (CG).
Retrieving results for chromium-cg-mac-snowleopard from Webkit Mac10.6 (CG).
Retrieving results for chromium-gpu-cg-mac-leopard from Webkit Mac10.5 (CG) - GPU.
Retrieving results for chromium-gpu-cg-mac-snowleopard from Webkit Mac10.6 (CG) - GPU.
Retrieving results for chromium-gpu-mac-snowleopard from Webkit Mac10.6 - GPU.
media/video-transformed.html
media/video-zoom-controls.html
media/video-layer-crash.html
Retrieving results for chromium-gpu-win-win7 from Webkit Win7 - GPU.
media/video-transformed.html
media/video-zoom-controls.html
media/video-layer-crash.html
Retrieving results for chromium-gpu-win-xp from Webkit Win - GPU.
media/video-transformed.html
media/video-zoom-controls.html
media/video-layer-crash.html
Retrieving results for chromium-linux-x86 from Webkit Linux 32.
Retrieving results for chromium-linux-x86_64 from Webkit Linux.
Retrieving results for chromium-mac-leopard from Webkit Mac10.5.
Retrieving results for chromium-mac-snowleopard from Webkit Mac10.6.
Retrieving results for chromium-win-vista from Webkit Vista.
Retrieving results for chromium-win-win7 from Webkit Win7.
Retrieving results for chromium-win-xp from Webkit Win.
Optimizing baselines for media/video-transformed.html.
Optimizing baselines for media/video-zoom-controls.html.
Optimizing baselines for media/video-layer-crash.html.
rniwa-macbookpro:webkit2 rniwa$ Tools/Scripts/rebaseline-chromium-webkit-tests
Where as old script would:
rniwa-macbookpro:webkit2 rniwa$ Tools/Scripts/rebaseline-chromium-webkit-tests
This script is depreciated. Please use use "webkit-patch rebaseline-expectations" instead.
If that command does not work properly, please file a bug and CC abarth. If you
really need to use the old script, run this command again with
--use-deprecated-script as the first argument.
rniwa-macbookpro:webkit2 rniwa$ Tools/Scripts/rebaseline-chromium-webkit-tests --use-deprecated-script
This script is depreciated. Please use use "webkit-patch rebaseline-expectations" instead.
If that command does not work properly, please file a bug and CC abarth. If you
really need to use the old script, run this command again with
--use-deprecated-script as the first argument.
Using /Users/rniwa/webkit2/LayoutTests
and /Users/rniwa/webkit2/LayoutTests/platform/chromium/test_expectations.txt
chromium-mac-lion: No tests to rebaseline.
chromium-mac-snowleopard: No tests to rebaseline.
chromium-mac-leopard: No tests to rebaseline.
chromium-cg-mac-lion: No tests to rebaseline.
chromium-cg-mac-snowleopard: No tests to rebaseline.
chromium-cg-mac-leopard: No tests to rebaseline.
chromium-win-win7: No tests to rebaseline.
chromium-win-vista: No tests to rebaseline.
chromium-win-xp: No tests to rebaseline.
chromium-linux-x86_64: No tests to rebaseline.
chromium-linux-x86: No tests to rebaseline.
chromium-gpu-mac-snowleopard: No tests to rebaseline.
chromium-gpu-win-win7: No tests to rebaseline.
chromium-gpu-linux-x86_64: Rebaselining 3 tests:
Using http://build.chromium.org/f/chromium/layout_test_results/Webkit_Linux_-_GPU/115857/layout-test-results.zip
Skipping media/video-transformed.html (matches platform/chromium-win)
Updating platform/chromium-gpu-linux/media/video-transformed-expected.png
Updating platform/chromium-gpu-linux/media/video-zoom-controls-expected.png
Updating platform/chromium-gpu-linux/media/video-layer-crash-expected.png
Rebaselining succeeded.
This makes webkit-patch rebaseline unusable.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
I'm not going to add support for the GPU configuration. If someone else wants to add it, I'm happy to review the patch. I would rather spend the effort removing the GPU configuration.
Dirk Pranke
both this script and this configuration are gone :).