| Summary: | Enable the [Supplemental] IDL on Qt | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
| Component: | WebKit Qt | Assignee: | Kentaro Hara <haraken> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, menard, vestbo, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 72138 | ||||||
| Attachments: |
|
||||||
|
Description
Kentaro Hara
2011-12-27 15:50:19 PST
Created attachment 120670 [details]
WIP patch to see if build passes
Comment on attachment 120670 [details] WIP patch to see if build passes View in context: https://bugs.webkit.org/attachment.cgi?id=120670&action=review > Source/WebCore/DerivedSources.pri:662 > +resolveSupplemental.commands = echo $(addprefix $${ROOT_WEBKIT_DIR}/Source/WebCore/, $$IDL_BINDINGS) | sed \'s/\\s/\\n/g\' > $$IDL_FILES_TMP && \ I am a bit afraid if the echo arguments exceed the OS limit on Qt/Mac and Qt/Win, although it passes Qt/Linux build. In AppleWebKit and Gtk, we have explicitly avoided this issue by $(foreach...) trick (See the patch of bug 74972), but it appears that qmake does not have $(foreach...) or something like that. That being said, I found much longer arguments when Qt links libwebcore.a at the final stage. So the echo arguments might not become a problem. Comment on attachment 120670 [details] WIP patch to see if build passes View in context: https://bugs.webkit.org/attachment.cgi?id=120670&action=review >> Source/WebCore/DerivedSources.pri:662 >> +resolveSupplemental.commands = echo $(addprefix $${ROOT_WEBKIT_DIR}/Source/WebCore/, $$IDL_BINDINGS) | sed \'s/\\s/\\n/g\' > $$IDL_FILES_TMP && \ > > I am a bit afraid if the echo arguments exceed the OS limit on Qt/Mac and Qt/Win, although it passes Qt/Linux build. In AppleWebKit and Gtk, we have explicitly avoided this issue by $(foreach...) trick (See the patch of bug 74972), but it appears that qmake does not have $(foreach...) or something like that. > > That being said, I found much longer arguments when Qt links libwebcore.a at the final stage. So the echo arguments might not become a problem. You'll probably want to check with some Qt folks after this lands to make sure its ok. Comment on attachment 120670 [details] WIP patch to see if build passes Clearing flags on attachment: 120670 Committed r103783: <http://trac.webkit.org/changeset/103783> All reviewed patches have been landed. Closing bug. Committed r103817: <http://trac.webkit.org/changeset/103817> |