Bug 75263 – [Chromium] uninitialized variable in fakeMouseMoveEventTimerFired

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Ryosuke Niwa]

20:48:57 memcheck_analyze.py [ERROR] FAIL! There were 1 errors: 
20:48:57 memcheck_analyze.py [ERROR] Command:      
UninitCondition
Conditional jump or move depends on uninitialised value(s)
  WebCore::PlatformEvent::PlatformEvent(WebCore::PlatformEvent::Type, bool, bool, bool, bool, double) (third_party/WebKit/Source/WebCore/platform/PlatformEvent.h:113)
  WebCore::PlatformMouseEvent::PlatformMouseEvent(WebCore::IntPoint const&, WebCore::IntPoint const&, WebCore::MouseButton, WebCore::PlatformEvent::Type, int, bool, bool, bool, bool, double) (third_party/WebKit/Source/WebCore/platform/PlatformMouseEvent.h:88)
  WebCore::EventHandler::fakeMouseMoveEventTimerFired(WebCore::Timer<WebCore::EventHandler>*) (third_party/WebKit/Source/WebCore/page/EventHandler.cpp:2426)
  WebCore::Timer<WebCore::EventHandler>::fired() (third_party/WebKit/Source/WebCore/platform/Timer.h:100)
  WebCore::ThreadTimers::sharedTimerFiredInternal() (third_party/WebKit/Source/WebCore/platform/ThreadTimers.cpp:115)
  WebCore::ThreadTimers::sharedTimerFired() (third_party/WebKit/Source/WebCore/platform/ThreadTimers.cpp:93)
  webkit_glue::WebKitPlatformSupportImpl::DoTimeout() (./webkit/glue/webkitplatformsupport_impl.h:135)
  base::BaseTimer<webkit_glue::WebKitPlatformSupportImpl, false>::TimerTask::Run() (./base/timer.h:173)
The report came from the `BookmarksUITest.BookmarksLoaded` test.
Suppression (error hash=#E0AE00D1F1BE808E#):
  For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
   <insert_a_suppression_name_here>
   Memcheck:Uninitialized
   fun:_ZN7WebCore13PlatformEventC2ENS0_4TypeEbbbbd
   fun:_ZN7WebCore18PlatformMouseEventC1ERKNS_8IntPointES3_NS_11MouseButtonENS_13PlatformEvent4TypeEibbbbd
   fun:_ZN7WebCore12EventHandler28fakeMouseMoveEventTimerFiredEPNS_5TimerIS0_EE
   fun:_ZN7WebCore5TimerINS_12EventHandlerEE5firedEv
   fun:_ZN7WebCore12ThreadTimers24sharedTimerFiredInternalEv
   fun:_ZN7WebCore12ThreadTimers16sharedTimerFiredEv
   fun:_ZN11webkit_glue25WebKitPlatformSupportImpl9DoTimeoutEv
   fun:_ZN4base9BaseTimerIN11webkit_glue25WebKitPlatformSupportImplELb0EE9TimerTask3RunEv
}

http://crbug.com/108620

[Ryosuke Niwa]

Created attachment 120609 [details]
Fixes the bug

The problem is that PlatformKeyboardEvent::getCurrentModifierState in PlatformKeyboardEventChromium.cpp never initializes arguments on Linux.

[Ryosuke Niwa]

Comment on attachment 120609 [details]
Fixes the bug

Oops, no change log entry :(

[WebKit Review Bot]

Attachment 120609 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryosuke Niwa]

Created attachment 120610 [details]
Added a change log entry

[Ryosuke Niwa]

Comment on attachment 120610 [details]
Added a change log entry

Thanks for the review, Tony!

[WebKit Review Bot]

Comment on attachment 120610 [details]
Added a change log entry

Clearing flags on attachment: 120610

Committed r103730: <http://trac.webkit.org/changeset/103730>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.