Bug 75256

Summary: [Qt] Make the inputMethodEvent set or confirm the composition.
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit QtAssignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kling, tonikitoo, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Kenneth Rohde Christiansen 2011-12-27 08:12:52 PST 
SSIA
Comment 1 Kenneth Rohde Christiansen 2011-12-27 08:14:00 PST 
Created attachment 120591 [details]
Patch
Comment 2 Chang Shu 2011-12-27 08:21:18 PST 
Comment on attachment 120591 [details]
Patch

No tests?
Comment 3 Kenneth Rohde Christiansen 2011-12-27 09:22:06 PST 
(In reply to comment #2)
> (From update of attachment 120591 [details])
> No tests?

There is a lot more needed before all of this is fully working. Everything in WebCore is already tested by layout tests, but we need to find out how to test this properly from our API side, especially as most issues we had so far were related to the fact that we never do sync calls. Also, all the input method support is not final in Qt5 yet.
Comment 4 Chang Shu 2011-12-27 17:56:36 PST 
Comment on attachment 120591 [details]
Patch

Good luck, man.
Comment 5 WebKit Review Bot 2011-12-27 19:16:48 PST 
Comment on attachment 120591 [details]
Patch

Clearing flags on attachment: 120591

Committed r103753: <http://trac.webkit.org/changeset/103753>
Comment 6 WebKit Review Bot 2011-12-27 19:16:53 PST 
All reviewed patches have been landed.  Closing bug.