Bug 75238

Summary: Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
Product: WebKit Reporter: Mary Wu <mawu>
Component: PlatformAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: leo.yang, rakuco, staikos, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Mary Wu
Reported 2011-12-26 19:47:36 PST
Enabling DOWNLOAD_ATTRIBUTE feature so that it could initiate download directly if it has the attribute in the link and don't need to open new blank page for the target="_blank". Enabling this feature also prepare for later blob feature.
Attachments
Patch (2.66 KB, patch)
2011-12-26 22:37 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Patch (2.68 KB, patch)
2011-12-27 00:38 PST, Mary Wu 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.10 KB, patch)
2012-01-04 01:03 PST, Leo Yang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mary Wu
Comment 1 2011-12-26 22:36:59 PST
add cc
Mary Wu
Comment 2 2011-12-26 22:37:23 PST
Created attachment 120567 [details] Patch
Leo Yang
Comment 3 2011-12-26 22:50:30 PST
Comment on attachment 120567 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120567&action=review Informal review. > ChangeLog:3 > + Enable DOWNLOAD_ATTRIBUTE in blackberry porting blackberry --> the BlackBerry? Also bug title? > Tools/ChangeLog:3 > + Enable DOWNLOAD_ATTRIBUTE in blackberry porting blackberry --> the BlackBerry? Also bug title? > Tools/Scripts/build-webkit:86 > $directoryUploadSupport, > + $downloadSupport, downloadSupport --> downloadAttributeSupport? > Tools/Scripts/build-webkit:143 > + { option => "download-attribute", desc => "Toggle download attribute support", > + define => "ENABLE_DOWNLOAD_ATTRIBUTE", default => isBlackBerry(), value =>\$downloadSupport }, Ditto.
Mary Wu
Comment 4 2011-12-26 22:54:01 PST
thanks, updating...
Mary Wu
Comment 5 2011-12-27 00:38:31 PST
Created attachment 120569 [details] Patch
Antonio Gomes
Comment 6 2011-12-27 16:07:20 PST
Comment on attachment 120569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120569&action=review > ChangeLog:7 > + Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting > + https://bugs.webkit.org/show_bug.cgi?id=75238 > + > + Reviewed by NOBODY (OOPS!). > + You guys do not write too much in changelogs :)
Mary Wu
Comment 7 2011-12-30 01:40:14 PST
Thanks, Antonio, will update change log when commit...
Leo Yang
Comment 8 2012-01-04 01:03:08 PST
Created attachment 121078 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-01-04 01:18:00 PST
Comment on attachment 121078 [details] Patch for landing Clearing flags on attachment: 121078 Committed r104020: <http://trac.webkit.org/changeset/104020>
WebKit Review Bot
Comment 10 2012-01-04 01:18:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.