Bug 75224

Summary: Fix mutation observer build after didMoveToNewDocument change
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch morrita: review+

Darin Adler
Reported 2011-12-25 23:17:46 PST
Fix mutation observer build after didMoveToNewDocument change
Attachments
Patch (3.09 KB, patch)
2011-12-25 23:18 PST, Darin Adler 		morrita: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2011-12-25 23:18:52 PST
Created attachment 120530 [details] Patch
Hajime Morrita
Comment 2 2011-12-26 03:00:50 PST
Comment on attachment 120530 [details] Patch Thanks for your help! Win bot redness looks flaky.
WebKit Review Bot
Comment 3 2011-12-26 03:53:30 PST
Comment on attachment 120530 [details] Patch Rejecting attachment 120530 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: bCore/dom/Node.cpp:2501: error: the address of 'void WebCore::didMoveToNewDocumentWasCalled()' will always evaluate as 'true' make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/Node.o] Error 1 make: *** Waiting for unfinished jobs.... Failed to run "['Tools/Scripts/build-webkit', '--debug', '--chromium', '--update-chromium']" exit_code: 2 lways evaluate as 'true' make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/Node.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/11038037
Darin Adler
Comment 4 2011-12-26 07:21:45 PST
Committed r103685: <http://trac.webkit.org/changeset/103685>
Lucas Forschler
Comment 5 2019-02-06 09:03:06 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.