Summary: | Fix mutation observer build after didMoveToNewDocument change | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
Component: | DOM | Assignee: | Darin Adler <darin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, morrita, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Darin Adler
2011-12-25 23:17:46 PST
Created attachment 120530 [details]
Patch
Comment on attachment 120530 [details]
Patch
Thanks for your help! Win bot redness looks flaky.
Comment on attachment 120530 [details] Patch Rejecting attachment 120530 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: bCore/dom/Node.cpp:2501: error: the address of 'void WebCore::didMoveToNewDocumentWasCalled()' will always evaluate as 'true' make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/Node.o] Error 1 make: *** Waiting for unfinished jobs.... Failed to run "['Tools/Scripts/build-webkit', '--debug', '--chromium', '--update-chromium']" exit_code: 2 lways evaluate as 'true' make: *** [out/Debug/obj.target/webcore_dom/Source/WebCore/dom/Node.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/11038037 Committed r103685: <http://trac.webkit.org/changeset/103685> Mass moving XML DOM bugs to the "DOM" Component. |