| Summary: | Change CSS canvas code that does HashMap get/set to use the more efficient add idiom | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | CSS | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 72477 | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2011-12-25 09:08:51 PST
Created attachment 120511 [details]
Patch
While working on bug 72477, I stumbled on this easy-to-improve call site. Comment on attachment 120511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120511&action=review > Source/WebCore/ChangeLog:9 > + (WebCore::Document::getCSSCanvasContext): Change local variable name of element to Did you mean “of result”? Comment on attachment 120511 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120511&action=review >> Source/WebCore/ChangeLog:9 >> + (WebCore::Document::getCSSCanvasContext): Change local variable name of element to > > Did you mean “of result”? Sorry I was unclear. But I meant of element as in "of the element", the variable has always held an element, it was just named result. Comment on attachment 120511 [details] Patch Clearing flags on attachment: 120511 Committed r103671: <http://trac.webkit.org/changeset/103671> All reviewed patches have been landed. Closing bug. |