Summary: | Add unittests for the C++ parser of prepare-ChangeLog | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
Component: | Tools / Tests | Assignee: | Kentaro Hara <haraken> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin, ddkilzer, rniwa, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 73531 | ||||||
Attachments: |
|
Description
Kentaro Hara
2011-12-24 09:30:46 PST
Created attachment 120495 [details]
Patch
Attachment 120495 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/prepare-..." exit_code: 1
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:29: Place brace on its own line for function definitions. [whitespace/braces] [4]
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:73: Declaration has space between type name and * in char *str [whitespace/declaration] [3]
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:82: Declaration has space between type name and * in char *str [whitespace/declaration] [3]
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:160: This { should be at the end of the previous line [whitespace/braces] [4]
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:170: This { should be at the end of the previous line [whitespace/braces] [4]
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:177: This { should be at the end of the previous line [whitespace/braces] [4]
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:184: This { should be at the end of the previous line [whitespace/braces] [4]
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:210: This { should be at the end of the previous line [whitespace/braces] [4]
Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:220: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 9 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 120495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120495&action=review >> Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:73 >> +char *str = "abcde" > > Declaration has space between type name and * in char *str [whitespace/declaration] [3] Is wrong style for pointer intentional? But we aren't really testing string literal parsing, right? So it seems like it's better to follow WebKit style here. >> Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:160 >> +{ > > This { should be at the end of the previous line [whitespace/braces] [4] One of these classes should follow WebKit style and put { on the same line as Class1. Committed r103669: <http://trac.webkit.org/changeset/103669> Comment on attachment 120495 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120495&action=review >>> Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:160 >>> +{ >> >> This { should be at the end of the previous line [whitespace/braces] [4] > > One of these classes should follow WebKit style and put { on the same line as Class1. Done. Thanks. |