Summary: | JPEG decoders should only save color profile markers if color management is enabled | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | noel gordon <noel.gordon> | ||||||||
Component: | New Bugs | Assignee: | noel gordon <noel.gordon> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, pkasting, rniwa, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 74400 | ||||||||||
Attachments: |
|
Description
noel gordon
2011-12-23 19:17:16 PST
Created attachment 120484 [details]
Patch
Comment on attachment 120484 [details] Patch Clearing flags on attachment: 120484 Committed r103651: <http://trac.webkit.org/changeset/103651> All reviewed patches have been landed. Closing bug. fast/images/ycbcr-with-cmyk-color-profile.html started failing after this change. Is this expected? http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fimages%2Fycbcr-with-cmyk-color-profile.html (In reply to comment #4) > fast/images/ycbcr-with-cmyk-color-profile.html started failing after this change. Is this expected? Nope, results look good to me, needs a rebaseline. Reopening to attach new patch. Created attachment 120489 [details]
Patch
Just noticed http://trac.webkit.org/changeset/103653, need to undo that. Created attachment 120490 [details]
Patch
(In reply to comment #5) > Is this expected? Chrome Skia Mac and Chrome CG Mac produce minor paint differences. Comment on attachment 120490 [details] Patch Rejecting attachment 120490 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11027442 Rebaselined the test in http://trac.webkit.org/changeset/103657. |