Bug 75167

Summary: [Qt] fast/canvas/canvas-largedraws.html crashes with newer Qt5
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Critical CC: hausmann, laszlo.gombos, ossy, rafael.lobo, webkit.review.bot
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
crash log
none
Patch none

Csaba Osztrogonác
Reported 2011-12-23 02:45:10 PST
Created attachment 120446 [details] crash log fast/canvas/canvas-largedraws.html started to crash after updating Qt5: https://lists.webkit.org/pipermail/webkit-qt/2011-December/002290.html This test now crashes with Qt5-WK1 and Qt5-WK2 too. Unfortunately I can't reproduce the crash in debug mode, because I got timeout. I attached the WK2 crash log I got in release mode. It is a P1/critical bug, because it is a regression and it is a crash.
Attachments
crash log (6.96 KB, text/plain)
2011-12-23 02:45 PST, Csaba Osztrogonác 		no flags
Details
Patch (1.25 KB, patch)
2012-01-08 23:03 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2011-12-23 02:54:51 PST
I skipped it, because we need green bots to be able catch new regressions - http://trac.webkit.org/changeset/103618
Simon Hausmann
Comment 2 2012-01-04 01:10:54 PST
It looks like it's simply running out of memory....
Simon Hausmann
Comment 3 2012-01-04 01:15:00 PST
I'll see if I can bisect qtbase to see what change caused it.
Simon Hausmann
Comment 4 2012-01-04 01:20:18 PST
I suspect ba3ed7b92c87e318904a279a2fea7e9e6c00cfb8 as that's the only change between the working and non-working qt5 qtbase that affects the files in question.
Simon Hausmann
Comment 5 2012-01-04 01:21:23 PST
Sorry, change 6506e0a6eec67985432427c630b148e825184c5d in qtbase is what I meant
Simon Hausmann
Comment 6 2012-01-04 01:21:41 PST
http://codereview.qt-project.org/#change,11007
Simon Hausmann
Comment 7 2012-01-04 04:20:59 PST
Made a test-case and filed upstream bug report https://bugreports.qt.nokia.com/browse/QTBUG-23443
Simon Hausmann
Comment 8 2012-01-08 23:03:22 PST
Created attachment 121622 [details] Patch
Simon Hausmann
Comment 9 2012-01-08 23:04:01 PST
For Ossy to review + land with the next qt5 update :). The bug should be fixed upstream now.
Csaba Osztrogonác
Comment 10 2012-01-08 23:24:46 PST
Comment on attachment 121622 [details] Patch r=me, I'll land it with the update.
Rafael Brandao
Comment 11 2012-01-17 06:24:42 PST
Ossy, can we close this one?
Csaba Osztrogonác
Comment 12 2012-01-17 06:25:48 PST
(In reply to comment #11) > Ossy, can we close this one? Please don't do it before cq land it. :)
Csaba Osztrogonác
Comment 13 2012-01-17 06:29:04 PST
Comment on attachment 121622 [details] Patch Clearing flags on attachment: 121622 Committed r105148: <http://trac.webkit.org/changeset/105148>
Csaba Osztrogonác
Comment 14 2012-01-17 06:29:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.