Bug 75153

Summary: Add Production configuration to gtest Xcode project
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, lforschler, mrowe, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66521    
Attachments:
Description Flags
Patch v1
none
Patch v2 none

David Kilzer (:ddkilzer)
Reported 2011-12-22 16:46:40 PST
The fix for Bug 66521 requires a header search path be added to WebCore.framework. In order to make gtest build properly internally at Apple, we need a separate Production configuration that will allow us to use a different path for WebCore.framework. Initially, the Production configuration will simply be based on the Release configuration.
Attachments
Patch v1 (10.02 KB, patch)
2011-12-22 17:10 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v2 (11.59 KB, patch)
2011-12-22 21:57 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2011-12-22 17:10:41 PST
Created attachment 120416 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 2 2011-12-22 21:57:23 PST
Created attachment 120433 [details] Patch v2
David Kilzer (:ddkilzer)
Comment 3 2011-12-22 21:58:17 PST
(In reply to comment #2) > Created an attachment (id=120433) [details] > Patch v2 Made "Production" the default configuration for xcodebuild. Tested Tools/Scripts/build-api-test and it still works as expected.
WebKit Review Bot
Comment 4 2012-01-03 08:25:27 PST
Comment on attachment 120433 [details] Patch v2 Clearing flags on attachment: 120433 Committed r103941: <http://trac.webkit.org/changeset/103941>
WebKit Review Bot
Comment 5 2012-01-03 08:25:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.