Bug 75145

Summary: Run tests in serial on SnowLeopard to avoid CFURLCache crashes
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, ojan, ossy, rniwa, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Simon Fraser (smfr)
Reported 2011-12-22 15:49:46 PST
CFURLCache seems to have issues when lots of processes are hitting the same cache. We should run the tests in serial on SnowLeopard to avoid this. See bug 75131
Attachments
Patch (2.64 KB, patch)
2012-02-02 15:17 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.85 KB, patch)
2012-02-02 15:26 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-12-22 16:07:48 PST
Sad times. I assume there is a radar about the crash? Or I guess one isn't needed since SL is history now... Do you know if only some of the tests crash? Can we run just those in serial?
Simon Fraser (smfr)
Comment 2 2011-12-22 16:10:27 PST
I was crashing just running fast/ There is a radar.
Eric Seidel (no email)
Comment 3 2012-02-02 12:49:27 PST
mac.py: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py Should override default_child_processes: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py#L166 to be 1 on SnowLeopard if it detects that this bug is present (or I guess always if the bug is always present). Alternatively, Mac.__init__ could use set_default("child_processes", 1) like it does for batch_size. I'm not really sure which is cleaner.
Dirk Pranke
Comment 4 2012-02-02 13:10:40 PST
overridding default_child_processes would be the recommended way to do it.
Eric Seidel (no email)
Comment 5 2012-02-02 15:17:56 PST
Created attachment 125196 [details] Patch
Eric Seidel (no email)
Comment 6 2012-02-02 15:26:08 PST
Created attachment 125198 [details] Patch for landing
WebKit Review Bot
Comment 7 2012-02-02 19:03:33 PST
Comment on attachment 125198 [details] Patch for landing Clearing flags on attachment: 125198 Committed r106616: <http://trac.webkit.org/changeset/106616>
WebKit Review Bot
Comment 8 2012-02-02 19:03:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.