Bug 75125
| Summary: | [chromium] Avoid reopening popup menu when <select> is clicked | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Erat <derat> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | jcivelli |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Daniel Erat
For issue 38105, code was added in WebViewImpl::mouseDown() to automatically close <select> popups in response to clicks, and then re-close them again if they were opened by the click (i.e. the <select> received the click). It looks like HTMLSelectElement already has code to handle closing the popup in response to left mouse down, so it seems like letting it do its thing may be better than closing the popup initially and then closing it again after it's been reopened.
I have a patch to do this but still need to test it (Jay suggests checking that this still works correctly on Mac and that WebKit/chromium/tests/PopupMenuTest.cpp still passes).
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Daniel Erat
I can no longer reproduce this bug.