Bug 75110 – [Chromium] fast/filesystem/op-restricted-chars.html fails on Windows

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Ryosuke Niwa]

fast/filesystem/op-restricted-chars.html is failing on Windows because you can't have : in filenames on Windows:
* Running: RestrictedChars
PASS Succeeded: "/".getFile("a<b")
PASS Succeeded: "/".getFile("a>b")
FAIL Got unexpected error 1 while "/".getFile("a:b")
FAIL Got error 1
PASS successfullyParsed is true

TEST COMPLETE

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Ffilesystem%2Fop-restricted-chars.html

[Eric U.]

Arg.  This doesn't hit the disk with that name; it must be having a problem with the file_util library.

[Eric U.]

(In reply to comment #1)
> Arg.  This doesn't hit the disk with that name; it must be having a problem with the file_util library.

Actually, Windows doesn't allow < or > either, but those are passing.  I'll dig in as soon as I can get my Windows dev setup up to date.

[Eric U.]

I tracked it down.  It's because the file name starts with "a:", so when we call BaseName on it [in Chromium code, not WebKit], it thinks that's a drive name and pulls it off.  So the test would have passed if it were "aa:b", but "a:b" fails.  Most likely I'll need to add an option to BaseName to ignore drive letters when used on paths that aren't really system paths.

[Eric U.]

Created attachment 130682 [details]
Patch

[Eric U.]

The bug was fixed in http://codereview.chromium.org/9370045.
You can see that it was successful at http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Ffilesystem%2Fop-restricted-chars.html.

[Eric U.]

Committed r110444: <http://trac.webkit.org/changeset/110444>