Summary: | [GStreamer] media/W3C failures | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Philippe Normand
2011-12-22 04:25:58 PST
Created attachment 127597 [details]
Patch
Comment on attachment 127597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127597&action=review What is the meaning of PASS "maybe" is "maybe" in the new baselines? Please take a look at the suggestion below before landing. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:288 > + KURL kurl(KURL(), url); > + String cleanUrl(url); I think it would be better here to do: if (kurl.isLocalFile()) { kurl.setQuery(""); kurl.removeFragmentIdentifier(); } Comment on attachment 127597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127597&action=review >> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:288 >> + String cleanUrl(url); > > I think it would be better here to do: > > if (kurl.isLocalFile()) { > kurl.setQuery(""); > kurl.removeFragmentIdentifier(); > } I actually tried this but setQuery() doesn't remove the leading '?'. (In reply to comment #2) > (From update of attachment 127597 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=127597&action=review > > What is the meaning of PASS "maybe" is "maybe" in the new baselines? > This is how the tests are written. You can see those messages in the other media/W3C baselines too :) I think these new baselines are for tests skipped on Mac, actually. For now I think it's safer to have them in the gtk directory. Committed r108327: <http://trac.webkit.org/changeset/108327> |