Bug 75073

Summary:

[EFL] Remove duplicate code and remove entry after freeing the matrix.

Product:

WebKit

Reporter:

JungJik Lee <jungjik.lee>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, gyuyoung.kim, hyuki.kim, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
proposal patch	none
fix type cast	none

JungJik Lee

Reported 2011-12-22 01:33:30 PST

Remove duplicate ewk_tile_unused_cache_freeze call and reorder function call. eina_matrixsparse_free(entry->matrix) should be called before removing the entry from inlist. Because entry count is decreased after calling eina_matrixsparce_free in _ewk_tile_matrix_cell_free.

Attachments
proposal patch (1.73 KB, patch) 2011-12-22 01:36 PST, JungJik Lee	no flags	Details Formatted Diff Diff
fix type cast (1.75 KB, patch) 2011-12-22 03:32 PST, JungJik Lee	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

JungJik Lee

Comment 1 2011-12-22 01:36:25 PST

Created attachment 120288 [details] proposal patch Proposal patch

Gyuyoung Kim

Comment 2 2011-12-22 02:27:26 PST

Comment on attachment 120288 [details] proposal patch LGTM. But, please use C++ type casting instead of C casting. For example, static_cast<Eina_Inlist*>

JungJik Lee

Comment 3 2011-12-22 02:49:49 PST

(In reply to comment #2) > (From update of attachment 120288 [details]) > LGTM. But, please use C++ type casting instead of C casting. For example, static_cast<Eina_Inlist*> I've tried to change it to C++ style, but it can not be compiled.

Gyuyoung Kim

Comment 4 2011-12-22 03:21:36 PST

(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 120288 [details] [details]) > > LGTM. But, please use C++ type casting instead of C casting. For example, static_cast<Eina_Inlist*> > > I've tried to change it to C++ style, but it can not be compiled. I succeed to build using "reinterpret_cast<Eina_Inlist*>(entry)"

JungJik Lee

Comment 5 2011-12-22 03:32:01 PST

Created attachment 120303 [details] fix type cast fix C++ style type cast.

JungJik Lee

Comment 6 2011-12-22 03:32:46 PST

(In reply to comment #5) > Created an attachment (id=120303) [details] > fix type cast > > fix C++ style type cast. reinterpret_cast works. good!

Gyuyoung Kim

Comment 7 2011-12-22 03:35:07 PST

Comment on attachment 120288 [details] proposal patch If you submit new patch, please set obsolete to previous patch.

Gyuyoung Kim

Comment 8 2011-12-22 19:25:36 PST

Comment on attachment 120303 [details] fix type cast Informal r+ on my side.

KwangHyuk

Comment 9 2011-12-26 18:00:14 PST

LGTM too. This patch seems to fix below error message. ERR<32424>:Ewk_Tiled_Backing_Store /home/hyuki/webkit/WebKit/Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:116

WebKit Review Bot

Comment 10 2011-12-27 21:14:12 PST

Comment on attachment 120303 [details] fix type cast Clearing flags on attachment: 120303 Committed r103756: <http://trac.webkit.org/changeset/103756>

WebKit Review Bot

Comment 11 2011-12-27 21:14:17 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.