Bug 75073

Summary: [EFL] Remove duplicate code and remove entry after freeing the matrix.
Product: WebKit Reporter: JungJik Lee <jungjik.lee>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, hyuki.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
proposal patch
none
fix type cast none

Description JungJik Lee 2011-12-22 01:33:30 PST 
Remove duplicate ewk_tile_unused_cache_freeze call and reorder function call.
eina_matrixsparse_free(entry->matrix) should be called before removing the entry from inlist.
Because entry count is decreased after calling eina_matrixsparce_free in _ewk_tile_matrix_cell_free.
Comment 1 JungJik Lee 2011-12-22 01:36:25 PST 
Created attachment 120288 [details]
proposal patch

Proposal patch
Comment 2 Gyuyoung Kim 2011-12-22 02:27:26 PST 
Comment on attachment 120288 [details]
proposal patch

LGTM. But, please use C++ type casting instead of C casting. For example, static_cast<Eina_Inlist*>
Comment 3 JungJik Lee 2011-12-22 02:49:49 PST 
(In reply to comment #2)
> (From update of attachment 120288 [details])
> LGTM. But, please use C++ type casting instead of C casting. For example, static_cast<Eina_Inlist*>

I've tried to change it to C++ style, but it can not be compiled.
Comment 4 Gyuyoung Kim 2011-12-22 03:21:36 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 120288 [details] [details])
> > LGTM. But, please use C++ type casting instead of C casting. For example, static_cast<Eina_Inlist*>
> 
> I've tried to change it to C++ style, but it can not be compiled.

I succeed to build using "reinterpret_cast<Eina_Inlist*>(entry)"
Comment 5 JungJik Lee 2011-12-22 03:32:01 PST 
Created attachment 120303 [details]
fix type cast

fix C++ style type cast.
Comment 6 JungJik Lee 2011-12-22 03:32:46 PST 
(In reply to comment #5)
> Created an attachment (id=120303) [details]
> fix type cast
> 
> fix C++ style type cast.

reinterpret_cast works. good!
Comment 7 Gyuyoung Kim 2011-12-22 03:35:07 PST 
Comment on attachment 120288 [details]
proposal patch

If you submit new patch, please set obsolete to previous patch.
Comment 8 Gyuyoung Kim 2011-12-22 19:25:36 PST 
Comment on attachment 120303 [details]
fix type cast

Informal r+ on my side.
Comment 9 KwangHyuk 2011-12-26 18:00:14 PST 
LGTM too.

This patch seems to fix below error message.


ERR<32424>:Ewk_Tiled_Backing_Store /home/hyuki/webkit/WebKit/Source/WebKit/efl/ewk/ewk_tiled_matrix.cpp:116
Comment 10 WebKit Review Bot 2011-12-27 21:14:12 PST 
Comment on attachment 120303 [details]
fix type cast

Clearing flags on attachment: 120303

Committed r103756: <http://trac.webkit.org/changeset/103756>
Comment 11 WebKit Review Bot 2011-12-27 21:14:17 PST 
All reviewed patches have been landed.  Closing bug.