Bug 75003

Summary:

[Qt] When building QtWebKit with the -ltcg configure option then it will fail to build

Product:

WebKit

Reporter:

andy.shaw

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, pierre.rossi

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fix for the build issue	none
Patch against trunk	hausmann: review+, hausmann: commit-queue-

andy.shaw

Reported 2011-12-21 03:17:17 PST

Created attachment 120165 [details] Fix for the build issue The reason it fails is because -GL is still specified for the compile options which is still there despite lines in WebCore.pri removing this from the flags. The reason being because it did not remove it from the right set of flags. Patch attached fixes this so it is removed from the right set of flags.

Attachments
Fix for the build issue (537 bytes, patch) 2011-12-21 03:17 PST, andy.shaw	no flags	Details Formatted Diff Diff
Patch against trunk (1.18 KB, patch) 2011-12-21 03:50 PST, andy.shaw	hausmann: review+ hausmann: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

andy.shaw

Comment 1 2011-12-21 03:50:53 PST

Created attachment 120167 [details] Patch against trunk

Simon Hausmann

Comment 2 2012-01-11 07:33:02 PST

Comment on attachment 120167 [details] Patch against trunk rs=me but the patch will have to be applied manually because it's missing the Tools/ directory prefix.

Pierre Rossi

Comment 3 2012-01-11 16:05:19 PST

(In reply to comment #2) > (From update of attachment 120167 [details]) > rs=me but the patch will have to be applied manually because it's missing the Tools/ directory prefix. ...and things had moved back to Source/WebCore in the meantime ;) Landed in r104758

andy.shaw

Comment 4 2012-01-11 21:17:39 PST

Thanks! Will this be included in Qt 4.8.1 as it is a build fix? If so then I will not push it to the internal group of patches we have for Qt Commercial 4.8.1.

Benjamin Poulain

Comment 5 2012-01-12 00:28:33 PST

Hi Andy, nice to see you here :)

Note You need to log in before you can comment on or make changes to this bug.