Bug 75003

Summary: [Qt] When building QtWebKit with the -ltcg configure option then it will fail to build
Product: WebKit Reporter: andy.shaw
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, pierre.rossi
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix for the build issue
none
Patch against trunk hausmann: review+, hausmann: commit-queue-

andy.shaw
Reported Wednesday, December 21, 2011 11:17:17 AM UTC
Created attachment 120165 [details] Fix for the build issue The reason it fails is because -GL is still specified for the compile options which is still there despite lines in WebCore.pri removing this from the flags. The reason being because it did not remove it from the right set of flags. Patch attached fixes this so it is removed from the right set of flags.
Attachments
Fix for the build issue (537 bytes, patch)
2011-12-21 03:17 PST, andy.shaw
no flags
Patch against trunk (1.18 KB, patch)
2011-12-21 03:50 PST, andy.shaw
hausmann: review+
hausmann: commit-queue-
andy.shaw
Comment 1 Wednesday, December 21, 2011 11:50:53 AM UTC
Created attachment 120167 [details] Patch against trunk
Simon Hausmann
Comment 2 Wednesday, January 11, 2012 3:33:02 PM UTC
Comment on attachment 120167 [details] Patch against trunk rs=me but the patch will have to be applied manually because it's missing the Tools/ directory prefix.
Pierre Rossi
Comment 3 Thursday, January 12, 2012 12:05:19 AM UTC
(In reply to comment #2) > (From update of attachment 120167 [details]) > rs=me but the patch will have to be applied manually because it's missing the Tools/ directory prefix. ...and things had moved back to Source/WebCore in the meantime ;) Landed in r104758
andy.shaw
Comment 4 Thursday, January 12, 2012 5:17:39 AM UTC
Thanks! Will this be included in Qt 4.8.1 as it is a build fix? If so then I will not push it to the internal group of patches we have for Qt Commercial 4.8.1.
Benjamin Poulain
Comment 5 Thursday, January 12, 2012 8:28:33 AM UTC
Hi Andy, nice to see you here :)
Note You need to log in before you can comment on or make changes to this bug.