Bug 74977

Summary: [Coverity] Address some uninit constructor issues in WebCore/dom
Product: WebKit Reporter: Greg Billock <gbillock>
Component: New BugsAssignee: Greg Billock <gbillock>
Status: RESOLVED FIXED    
Severity: Normal CC: groby, macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Greg Billock 2011-12-20 17:04:14 PST 
[Coverity] Address some uninit constructor issues in WebCore/dom
Comment 1 Greg Billock 2011-12-20 17:05:31 PST 
Created attachment 120117 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-12-21 16:22:04 PST 
Comment on attachment 120117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120117&action=review

> Source/WebCore/dom/DeviceMotionData.cpp:79
> +    , m_interval(0.0)

Please, no ".0".

> Source/WebCore/dom/DeviceOrientation.cpp:48
> +    , m_alpha(0.0)
> +    , m_beta(0.0)
> +    , m_gamma(0.0)

Ditto.
Comment 3 Greg Billock 2011-12-22 08:49:35 PST 
Created attachment 120326 [details]
Patch
Comment 4 Greg Billock 2011-12-22 08:51:46 PST 
Comment on attachment 120117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=120117&action=review

>> Source/WebCore/dom/DeviceMotionData.cpp:79
>> +    , m_interval(0.0)
> 
> Please, no ".0".

Done

>> Source/WebCore/dom/DeviceOrientation.cpp:48
>> +    , m_gamma(0.0)
> 
> Ditto.

Done.
Comment 5 Greg Billock 2012-01-04 13:15:03 PST 
Any further comments on this patch?
Comment 6 WebKit Review Bot 2012-01-11 12:42:14 PST 
Comment on attachment 120326 [details]
Patch

Clearing flags on attachment: 120326

Committed r104734: <http://trac.webkit.org/changeset/104734>
Comment 7 WebKit Review Bot 2012-01-11 12:42:18 PST 
All reviewed patches have been landed.  Closing bug.