| Summary: | [Qt][WK2] Add tests for favicon and fix icon url decoding issue | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rafael Brandao <rafael.lobo> | ||||
| Component: | New Bugs | Assignee: | Rafael Brandao <rafael.lobo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | rafael.lobo, webkit.review.bot, zoltan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Rafael Brandao
2011-12-20 15:38:11 PST
Created attachment 120102 [details]
Patch
I've found today a bug where the QtWebIconDatabaseClient emitted the signal that an icon was ready, but when the image provider tried to get it, it wasn't there. Problem: url had a white space originally but internally (KURL -> String conversion) we stay with the url percent encoded. When we transform it to QUrl, the conversion to QString will not do the same (so we would have a white space where it should have a "%20" for example). And as we get a QString at the image provider level, we would get the url already percent decoded, and then we couldn't use it unless we encode it again. I've also added a test to cover this misbehavior. Comment on attachment 120102 [details]
Patch
Tricky :) Hadn't thought that qdeclarative provides the decoded url, but makes perfect sense.
Comment on attachment 120102 [details]
Patch
cq+ as requested by rafael on IRC.
Comment on attachment 120102 [details] Patch Clearing flags on attachment: 120102 Committed r103413: <http://trac.webkit.org/changeset/103413> All reviewed patches have been landed. Closing bug. |