Bug 74967

Summary: [Qt][WK2] Add tests for favicon and fix icon url decoding issue
Product: WebKit Reporter: Rafael Brandao <rafael.lobo>
Component: New BugsAssignee: Rafael Brandao <rafael.lobo>
Status: RESOLVED FIXED    
Severity: Normal CC: rafael.lobo, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rafael Brandao
Reported 2011-12-20 15:38:11 PST
[Qt][WK2] Add tests for favicon and fix icon url decoding issue
Attachments
Patch (12.86 KB, patch)
2011-12-20 15:43 PST, Rafael Brandao 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rafael Brandao
Comment 1 2011-12-20 15:43:09 PST
Created attachment 120102 [details] Patch
Rafael Brandao
Comment 2 2011-12-20 15:50:48 PST
I've found today a bug where the QtWebIconDatabaseClient emitted the signal that an icon was ready, but when the image provider tried to get it, it wasn't there. Problem: url had a white space originally but internally (KURL -> String conversion) we stay with the url percent encoded. When we transform it to QUrl, the conversion to QString will not do the same (so we would have a white space where it should have a "%20" for example). And as we get a QString at the image provider level, we would get the url already percent decoded, and then we couldn't use it unless we encode it again. I've also added a test to cover this misbehavior.
Simon Hausmann
Comment 3 2011-12-21 00:26:35 PST
Comment on attachment 120102 [details] Patch Tricky :) Hadn't thought that qdeclarative provides the decoded url, but makes perfect sense.
Jesus Sanchez-Palencia
Comment 4 2011-12-21 08:01:21 PST
Comment on attachment 120102 [details] Patch cq+ as requested by rafael on IRC.
WebKit Review Bot
Comment 5 2011-12-21 10:22:13 PST
Comment on attachment 120102 [details] Patch Clearing flags on attachment: 120102 Committed r103413: <http://trac.webkit.org/changeset/103413>
WebKit Review Bot
Comment 6 2011-12-21 10:22:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.