Bug 74913

Summary: Implement CSS clip property in CSSStyleApplyProperty.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: CSSAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo, kling, macpherson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Luke Macpherson 2011-12-19 21:58:38 PST 
Implement CSS clip property in CSSStyleApplyProperty.
Comment 1 Luke Macpherson 2011-12-19 22:01:31 PST 
Created attachment 119988 [details]
Patch
Comment 2 Early Warning System Bot 2011-12-19 22:10:03 PST 
Comment on attachment 119988 [details]
Patch

Attachment 119988 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10967460
Comment 3 Gyuyoung Kim 2011-12-19 22:15:19 PST 
Comment on attachment 119988 [details]
Patch

Attachment 119988 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10965452
Comment 4 Gustavo Noronha (kov) 2011-12-19 22:28:00 PST 
Comment on attachment 119988 [details]
Patch

Attachment 119988 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10964470
Comment 5 WebKit Review Bot 2011-12-20 13:59:36 PST 
Comment on attachment 119988 [details]
Patch

Attachment 119988 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10994337
Comment 6 Luke Macpherson 2011-12-20 16:03:19 PST 
Created attachment 120107 [details]
Patch
Comment 7 Andreas Kling 2012-01-20 10:21:40 PST 
Comment on attachment 120107 [details]
Patch

Lookin' good! One step closer to tossing the applyProperty() spaghetti :)
Comment 8 WebKit Review Bot 2012-01-23 11:20:38 PST 
Comment on attachment 120107 [details]
Patch

Rejecting attachment 120107 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
.h
Hunk #2 succeeded at 3674 (offset 40 lines).
patching file Source/WebCore/css/CSSStyleApplyProperty.cpp
Hunk #3 succeeded at 1791 (offset 80 lines).
patching file Source/WebCore/css/CSSStyleSelector.cpp
Hunk #1 FAILED at 2687.
Hunk #2 succeeded at 3767 (offset 90 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/css/CSSStyleSelector.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/11118432
Comment 9 Luke Macpherson 2012-01-23 15:32:13 PST 
Created attachment 123636 [details]
Patch for landing
Comment 10 WebKit Review Bot 2012-01-23 21:44:38 PST 
Comment on attachment 123636 [details]
Patch for landing

Clearing flags on attachment: 123636

Committed r105693: <http://trac.webkit.org/changeset/105693>
Comment 11 WebKit Review Bot 2012-01-23 21:44:43 PST 
All reviewed patches have been landed.  Closing bug.