Bug 74905

Summary: Remove unused code for non-speculative Arith operations from DFG JIT
Product: WebKit Reporter: Yuqiang Xian <yuqiang.xian>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch none

Yuqiang Xian
Reported 2011-12-19 19:21:48 PST
The code is never used and in fact is wrong especially for the 32_64 version, for example the nonSpeculativeBasicArithOp may require 6 GPRs while there are only 5 available on X86. So just remove such code to avoid potential confusions. Patch forthcoming.
Attachments
the patch (24.14 KB, patch)
2011-12-19 19:24 PST, Yuqiang Xian 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yuqiang Xian
Comment 1 2011-12-19 19:24:55 PST
Created attachment 119974 [details] the patch
Yuqiang Xian
Comment 2 2011-12-19 20:35:39 PST
Landed as r103299: http://trac.webkit.org/changeset/103299
Yuqiang Xian
Comment 3 2011-12-19 20:36:20 PST
Comment on attachment 119974 [details] the patch clearing flags.
Note You need to log in before you can comment on or make changes to this bug.