Bug 74901

Summary: [Refactoring] Replace imp with impl in CodeGeneratorJS.pm
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: JavaScriptCoreAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2011-12-19 18:43:19 PST
As pointed out in bug 74837, the generated code by CodeGeneratorJS.pm includes both 'imp' and 'impl'. We should unify them into 'impl'.
Attachments
Patch (107.41 KB, patch)
2011-12-19 19:43 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2011-12-19 19:43:17 PST
Created attachment 119978 [details] Patch
Kentaro Hara
Comment 2 2011-12-19 19:44:46 PST
Patch diff is hard to read, but I just replaced imp with impl. I confirmed that "perl -lne 'print if /imp[^l]/' CodeGeneratorJS.pm" outputs nothing.
WebKit Review Bot
Comment 3 2011-12-20 03:44:49 PST
Comment on attachment 119978 [details] Patch Clearing flags on attachment: 119978 Committed r103315: <http://trac.webkit.org/changeset/103315>
WebKit Review Bot
Comment 4 2011-12-20 03:44:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.